fix(dev-server): fix loading css error - #3
Merged
Conversation
Contributor
|
Thanks! tested it on my mac as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Takuya-san,
Found another issue: theme CSS isn't loading at all when the dev server starts — comes up completely unstyled.
Turns out Vite needs the
/@fsprefix to serve absolute filesystem paths through import() — dev-server.tsx was just concatenating the raw path, which doesn't work. I also tried WSL since the docs suggest that should sidestep path issues, but it failed the same way there too.Fix:
The
normalizedBasestep is there to handle Windows paths (backslashes, drive letters) — Unix paths don't need it, but the normalize is harmless either way.Tested on Windows and WSL, both work now.