fix: resolve README disk_usage constraint failures (CEL cross-type numerics + YAML regex escaping)#48
Draft
Copilot wants to merge 3 commits into
Draft
fix: resolve README disk_usage constraint failures (CEL cross-type numerics + YAML regex escaping)#48Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix invalid constraints in README example
fix: resolve README disk_usage constraint failures (CEL cross-type numerics + YAML regex escaping)
Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs in the README
disk_usageexample caused constraint compilation/evaluation errors for anyone following the quickstart.Changes
pkg/common/constraints.go— Addcel.CrossTypeNumericComparisons(true)to the CEL env options.number-typed params are bound asdouble, so comparing them against integer literals (e.g.max_depth >= 1) failed without this option.README.md— Fix YAML quoting on the regex constraint. The double-quoted YAML string"directory.matches('^[\\w\\s./\\-_]+$')"has its backslashes consumed by the YAML parser (\\w→\w), leaving invalid escape sequences in the CEL string literal. Changed to YAML single-quoted form which passes backslashes through verbatim:pkg/common/constraints_test.go— Added test cases covering pass/fail fordoubleparams compared against integer literals (max_depth >= 1 && max_depth <= 3).