Skip to content

Add before and after compile hooks#18

Open
loverde wants to merge 7 commits into
incuna:masterfrom
loverde:master
Open

Add before and after compile hooks#18
loverde wants to merge 7 commits into
incuna:masterfrom
loverde:master

Conversation

@loverde

@loverde loverde commented Apr 7, 2016

Copy link
Copy Markdown

This change adds optional hooks for code to perform actions before or after the compilation. E.g. in this plunkr there is an example of adding an "ng-model" to the DOM in the before hook so that it is part of the compilation.

https://plnkr.co/edit/f4LobH?p=preview

restrict: 'A',
scope: {
beforeCompile: '&bindHtmlBeforeCompile',
afterCompile: '&bindHtmlAfterCompile'

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to isolate the scope here.

@maxpaj

maxpaj commented Feb 8, 2017

Copy link
Copy Markdown

Is this being merged?

@wytrych

wytrych commented Feb 8, 2017

Copy link
Copy Markdown
Collaborator

See my comment #18 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants