Skip to content

Fix: Revert memories fix - #678

Merged
JW-CH merged 2 commits into
mainfrom
revert-memories-fix
Jul 17, 2026
Merged

Fix: Revert memories fix#678
JW-CH merged 2 commits into
mainfrom
revert-memories-fix

Conversation

@JW-CH

@JW-CH JW-CH commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Bug Fixes
    • Improved date-based filtering to use calendar dates consistently, reducing unexpected timezone-related behavior.
  • Documentation
    • Clarified album and user identifier descriptions in the API documentation.
    • Documented supported date filter formats with updated examples.
  • Chores
    • Updated the API specification version to 3.0.3.

@JW-CH JW-CH added the fix Something was fixed label Jul 17, 2026
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b8ce9575-7959-4382-bc98-fbed10cf2365

📥 Commits

Reviewing files that changed from the base of the PR and between 4372770 and cb81f9a.

📒 Files selected for processing (3)
  • ImmichFrame.Core/Api/ImmichApi.cs
  • ImmichFrame.Core/Logic/Pool/MemoryAssetsPool.cs
  • ImmichFrame.Core/OpenAPIs/immich-openapi-specs.json
💤 Files with no reviewable changes (2)
  • ImmichFrame.Core/Logic/Pool/MemoryAssetsPool.cs
  • ImmichFrame.Core/Api/ImmichApi.cs

📝 Walkthrough

Walkthrough

The change removes Immich request timezone-offset rewriting, removes its obsolete explanatory comment, and updates the OpenAPI specification with album parameter metadata, date-only filters, and version 3.0.3.

Changes

Timezone handling and API contract

Layer / File(s) Summary
Remove request timezone correction
ImmichFrame.Core/Api/ImmichApi.cs, ImmichFrame.Core/Logic/Pool/MemoryAssetsPool.cs
Deletes PrepareRequest and EnsureTimezoneOffset, while removing the related comment from memory loading logic.
Refresh OpenAPI definitions
ImmichFrame.Core/OpenAPIs/immich-openapi-specs.json
Adds album parameter descriptions and deprecation metadata, changes “Filter by date” schemas to date-only values, and updates the specification version to 3.0.3.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: reverting the earlier memories-related fix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-memories-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@JW-CH
JW-CH merged commit 319affe into main Jul 17, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Something was fixed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant