[standard] Fix crash when filter callback unsets StreamBucket::$data - #265
Open
iliaal wants to merge 1 commit into
Open
[standard] Fix crash when filter callback unsets StreamBucket::$data#265iliaal wants to merge 1 commit into
iliaal wants to merge 1 commit into
Conversation
stream_bucket_prepend()/append() assumed a successful zend_read_property() of StreamBucket::$data always yields a string, but for an unset typed property it throws while returning &EG(uninitialized_zval), so Z_STRLEN_P() dereferenced a NULL string pointer and crashed when the brigade was consumed. Reject non-string reads up front (rethrowing any pending exception) so the bucket is never re-attached with undefined data; the sibling $bucket property path is already safe because zend_fetch_resource_ex() rejects non-resources.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stream_bucket_prepend() and stream_bucket_append() assumed that a successful zend_read_property() of the typed StreamBucket::$data property always yields a string, but when the property has been unset in the filter callback the read throws while returning &EG(uninitialized_zval), so Z_STRLEN_P() dereferenced a NULL string pointer and crashed once the brigade was consumed. The fix rejects non-string reads up front, rethrowing any pending exception, so a bucket is never re-attached with undefined data. The sibling $bucket property path is already safe because zend_fetch_resource_ex() rejects non-resources. A regression test is included.