[SimpleXML] Fix namespace filter on element returned by addChild() - #259
Open
iliaal wants to merge 1 commit into
Open
[SimpleXML] Fix namespace filter on element returned by addChild()#259iliaal wants to merge 1 commit into
iliaal wants to merge 1 commit into
Conversation
The SimpleXMLElement wrapper returned by addChild() stored the QName prefix as the iteration namespace filter in href mode, so property accesses on the returned element compared the prefix against namespace hrefs and never matched the children that asXML() shows. Derive the filter from the namespace actually attached to the new node and use prefix mode; sibling audit found no other call site passing a prefix in href mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SimpleXMLElement returned by SimpleXMLElement::addChild() stored the QName prefix (e.g. "a" from "a:kid") as the iteration namespace filter in href mode, so any subsequent property access on that element compared the prefix against namespace hrefs and never matched the children that asXML() shows; $c->inner was empty and isset($c->inner) false even though the child element existed. The fix derives the filter from the namespace actually attached to the newly created node (newnode->ns->prefix) and switches to prefix mode, which also handles qname prefixes that differ from the resolved namespace declaration. A sibling audit of node_as_zval_str()/node_as_zval() call sites found no other site passing a QName prefix in href mode. Red/green verified: new phpt fails unpatched, passes patched, ext/simplexml suite has zero failures.