pdo: report correct argument number for constructor option errors - #257
Open
iliaal wants to merge 1 commit into
Open
pdo: report correct argument number for constructor option errors#257iliaal wants to merge 1 commit into
iliaal wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an attribute passed through the PDO constructor options array failed to set, the resulting error message named argument #3 ($password) instead of argument #4 ($options), because pdo_dbh_attribute_set() was called from php_pdo_internal_construct_driver() with a hardcoded value_arg_num of 3. This passes 4 so errors like an invalid PDO::ATTR_ERRMODE now correctly report Argument #4 ($options). The only other caller, PDO::setAttribute(), already passes the correct number and was audited; a test asserting the corrected message is included and fails without the patch.