dom: invalidate node list caches on class attribute mutations - #256
Open
iliaal wants to merge 1 commit into
Open
dom: invalidate node list caches on class attribute mutations#256iliaal wants to merge 1 commit into
iliaal wants to merge 1 commit into
Conversation
Reflected attribute writes such as className and id, classList mutations, and removeAttribute()/removeAttributeNS()/removeAttributeNode() modified attributes without bumping the document cache tag, so live HTMLCollection caches like getElementsByClassName() kept serving stale lengths and items. Invalidate the node list caches at every one of these mutation points, matching what setAttribute() already does through dom_attr_value_will_change(). Sibling audit: Attr:: writes, setAttribute(), setAttributeNode() and setAttributeNS() were verified to already invalidate; php_dom_ns_compat_mark_attribute() only mirrors namespace declarations during reconciliation and is not user-visible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mutating an element's class through the reflected className property, classList mutations, or removing attributes via removeAttribute(), removeAttributeNS() and removeAttributeNode() modified the underlying attribute without bumping the document cache tag, so live collections such as getElementsByClassName() kept returning stale lengths and items afterwards. This invalidates the node list caches at each of these mutation points, matching what setAttribute() already does via dom_attr_value_will_change(). Other attribute write paths (Attr::$value, setAttributeNode, setAttributeNS) were audited and already invalidate correctly.