Adopt foundation utility packages#59
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors and modularizes the packages/node-utils package by splitting its monolithic files into dedicated modules (account.ts, chain.ts, format.ts, logging.ts, retryable.ts, and runtime_config.ts), alongside updating dependencies and build configurations. Feedback on the changes identifies a correctness bug in the logging utility where primitive null and undefined values are incorrectly serialized as "Empty Error". To resolve this, it is recommended to move the fallback default to the entry point of errorToLog so that primitive values can be returned directly.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request refactors and modularizes several workspace packages, including @ickb/node-utils, @ickb/testkit, and @ickb/utils. It splits monolithic files into smaller, single-responsibility modules (such as account.ts, chain.ts, format.ts, logging.ts, retryable.ts, and runtime_config.ts), upgrades the TypeScript target to ES2024, configures API Extractor, and introduces a custom script to rewrite declaration file imports. Additionally, it updates dependencies, refactors test configurations to use Vitest 4, and adds comprehensive test coverage across the packages. I have no feedback to provide as there are no review comments to assess.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
LGTM Phroi %270 |
1 participant
Why
The migration needs the shared foundation packages in place before moving higher-level iCKB packages. This keeps the first slice focused on utility, test, and Node runtime helpers while preserving current downstream package builds.
Changes
@ickb/utilsaround the copied foundation helpers, removes unused heap/shuffle/sum APIs, and adds API Extractor build scaffolding.@ickb/testkitwith reusable CKB fixtures while keeping the existinghashhelper for current tests.@ickb/node-utilsinto focused account, chain, formatting, logging, retry, and runtime-config modules with focused tests.