Conversation
tischsoic
force-pushed
the
new-menu
branch
2 times, most recently
from
June 18, 2026 10:08
444ca77 to
5f89cfa
Compare
tischsoic
commented
Jun 23, 2026
|
|
||
| for (const tooltipNode of tooltipsNode) { | ||
| bootstrap.Tooltip.getOrCreateInstance(tooltipNode).hide(); | ||
| const tooltipInstance = bootstrap.Tooltip.getInstance(tooltipNode); |
Contributor
Author
There was a problem hiding this comment.
Note: fix needed to avoid creating tooltip instances when hiding tooltips, which circumvent our parse function's custom logic.
tischsoic
marked this pull request as ready for review
June 23, 2026 07:21
ibexa-workflow-automation-1
Bot
requested review from
GrabowskiM,
OstafinL,
albozek,
alekmick and
dew326
and removed request for
a team
June 23, 2026 07:22
GrabowskiM
reviewed
Jun 23, 2026
albozek
reviewed
Jun 25, 2026
albozek
approved these changes
Jun 29, 2026
GrabowskiM
approved these changes
Jun 30, 2026
dew326
approved these changes
Jun 30, 2026
tischsoic
force-pushed
the
ds-development
branch
from
July 15, 2026 10:57
1396402 to
f474be6
Compare
OstafinL
approved these changes
Jul 31, 2026
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…branches Points CI at design-system-twig#new-menu, product-catalog#new-menu and admin-ui-assets#new-menu (build of design-system#new-menu) so browser tests run against the combined ticket state. Must be removed before merging. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…s alias product-catalog is not resolvable in the AdminUI-OSS jobs (commercial package), and the product requires admin-ui-assets dev-6.0-next, so the override must be aliased accordingly. Must be removed before merging. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
This branch includes a temporary commit (
dependencies.json) that points CI atdesign-system-twig#new-menu and admin-ui-assets#new-menu (a CI-only build of
design-system#new-menu, based on 6.0-next) so browser tests run against the combined
IBX-11909 state. product-catalog#new-menu is NOT included — it is not resolvable in the
AdminUI-OSS jobs. Both the commits and the admin-ui-assets branch must be removed before merging.
-->
Description:
For QA:
Documentation: