bench: add flow control regression repro#919
Draft
brentechols wants to merge 1 commit into
Draft
Conversation
3545e6f to
321be65
Compare
Author
|
Updated run with the corrected checked-in benchmark shape. The benchmark now keeps the in-flight response futures inside the connection task, matching the local repro harness. The earlier draft PR body result came from a spawned-response-task shape and should be ignored. Slow configuration: H2_BENCH_REQUESTS=300
H2_BENCH_CONNECTIONS=1
H2_BENCH_STREAMS=8
H2_BENCH_RESPONSE_SIZE=1048576
H2_BENCH_STREAM_WINDOW_SIZE=65535
H2_BENCH_CONNECTION_WINDOW_SIZE=65535
H2_BENCH_WORKER_THREADS=8
H2_BENCH_NODELAY=false
cargo bench --bench flow_control_reproResults from this machine:
That puts #917 at ~0.146x the master baseline for this shape, or about 6.9x slower. Validation after updating the benchmark:
No new external dependencies are required; this uses the existing repo dependency set. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a standalone benchmark for the single-connection flow-control shape that showed the large regression while evaluating #917.
Default shape:
Run with:
cargo bench --bench flow_control_reproThe shape can be adjusted with
H2_BENCH_*environment variables for request count, connection count, streams, body sizes, windows, worker threads, idle/spin delay, and TCP_NODELAY.This uses only the repo's existing dependencies/dev-dependencies; no new external crate is required.
Local validation:
cargo fmt --checkcargo check --benchescargo bench --bench flow_control_repro