feat(aggregation): add MAX to AggregationMethod - #6
Merged
Conversation
Peak channels (e.g. window-max discharge a flood threshold is set on) could not be declared through FI. MAX makes them declarable. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
sandrohuni
force-pushed
the
feat/aggregation-max
branch
from
August 14, 2026 11:03
02ac13f to
5eab82a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
AggregationMethodwas{SUM, MEAN}. A peak channel — the window max a flood threshold is set on — could not be declared at all, making the peak-target feature undeclarable through FI.Change
MAX = "max"added toforecast_interface.common.aggregation.AggregationMethoddocs/input_requirement.mdaggregation notes mentionMAXaggregationstays optional; no other FI change.Verification
uv run pytest→ 185 passed.uv run mypy→ clean.uv run ruff check→ clean.Tagged
v0.1.19for downstream pinning (aquacast bumps its pin fromv0.1.18).🤖 Generated with Claude Code