Skip to content

Fix TileLang ST CI failures#907

Draft
mouliangyu wants to merge 6 commits into
hw-native-sys:mainfrom
mouliangyu:codex/fix-tilelang-st-ci
Draft

Fix TileLang ST CI failures#907
mouliangyu wants to merge 6 commits into
hw-native-sys:mainfrom
mouliangyu:codex/fix-tilelang-st-ci

Conversation

@mouliangyu

@mouliangyu mouliangyu commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Fix TileOps lowering/runtime issues exposed by full TileLang ST, including tload/tmov-to-scale/tstore-fp scaling payloads and sync effects.
  • Add focused lit coverage for MAT->scaling pipe selection and tstore_fp memory effects.
  • Restore the earlier incorrect test deletion/filtering direction: final PR diff has no net changes to run_st.py, testcase CMakeLists, tcvt, or mx_fp4.py versus main. Full regression stays enabled.
  • Update the acc_store vector pre_quant negative lit case so ui64 remains a valid scaling payload and ui32 is used for the invalid payload check.

Validation

  • cmake --build build-main-llvm21 -j64 --target ptoas
  • CI=1 PTOAS_BIN=$PWD/build-main-llvm21/tools/ptoas/ptoas bash test/tilelang_st/script/run_ci.sh -r sim -v a5 --jobs 64
    • TileLang ST summary: passed=106 failed=0 total=106
    • tcvt ran the full 251-case set; no case filtering.
  • ptoas + FileCheck: test/lit/pto/tmov_m2s_pipe_selection.pto
  • ptoas + FileCheck: test/lit/vpto/tstore_fp_sync_effects.pto
  • ptoas + FileCheck: test/lit/vpto/acc_store_verify_invalid_pre_quant_vec_payload_type.pto

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

@reedhecre

reedhecre commented Jul 7, 2026

Copy link
Copy Markdown

Codex Review

该评论由 review 机器人自动更新。

  • PR: Fix TileLang ST CI failures #907 Fix TileLang ST CI failures
  • Author: mouliangyu
  • Base/Head: main / codex/fix-tilelang-st-ci
  • Head SHA: 83f1fffd5c23
  • Trigger: PR 有新提交
  • Generated At: 2026-07-08T03:10:45Z
  • Previous Head SHA: d2603548623b
  • Status: failed at codex-review (exit=1)

Summary

Review failed at stage codex-review: exit=1

Findings

未生成结构化 findings,因为 review 过程提前失败。

Log Tail

 .../a5/src/st/testcase/fp8_load_test/gen_data.py   |  33 +++
 .../a5/src/st/testcase/fp8_load_test/launch.cpp    |  29 +++
 .../npu/a5/src/st/testcase/fp8_load_test/main.cpp  | 120 +++++++++++
 .../npu/a5/src/st/testcase/st_common.py            |  64 ++++++
 .../npu/a5/src/st/testcase/tgemv_mx/cases.py       |   6 +-
 .../npu/a5/src/st/testcase/tgemv_mx/gen_data.py    |  28 ++-
 .../npu/a5/src/st/testcase/tload_mat/gen_data.py   |  28 ++-
 .../npu/a5/src/st/testcase/tload_mat/tload_mat.pto |  89 +++++---
 .../a5/src/st/testcase/tmatmul_bias_mx/cases.py    |   6 +-
 .../a5/src/st/testcase/tmatmul_bias_mx/gen_data.py |  37 ++--
 .../npu/a5/src/st/testcase/tmatmul_mx/cases.py     |   6 +-
 .../npu/a5/src/st/testcase/tmatmul_mx/gen_data.py  |  37 ++--
 .../npu/a5/src/st/testcase/tstore_acc2gm/cases.py  |   5 +-
 .../a5/src/st/testcase/tstore_acc2gm/gen_data.py   |  37 ++--
 .../a5/src/st/testcase/tstore_acc2gm/launch.cpp    |   8 +-
 .../npu/a5/src/st/testcase/tstore_acc2gm/main.cpp  |   6 +-
 .../st/testcase/tstore_acc2gm/tstore_acc2gm.pto    | 160 +++++++++++----
 tilelang-dsl/docs/user_guide/12-cube-operations.md |   5 +-
 .../python/tilelang_dsl/pybind_renderer.py         |   1 +
 tilelang-dsl/python/tilelang_dsl/semantic.py       |   6 +-
 35 files changed, 1145 insertions(+), 245 deletions(-)
===== END STAGE clone rc=0 @ 2026-07-08 11:10:34 =====

===== STAGE codex-review @ 2026-07-08 11:10:34 =====
set -euo pipefail
cd '/tmp/ptoas-pr-review-monitor/runs/20260708_111027_pr907/repo'
'codex' exec -C '/tmp/ptoas-pr-review-monitor/runs/20260708_111027_pr907/repo' -s read-only -c 'model_provider="codereview"' -c 'model="gpt-5.4"' -c 'model_reasoning_effort="xhigh"' --output-schema '/tmp/ptoas-pr-review-monitor/runs/20260708_111027_pr907/review_schema.json' -o '/tmp/ptoas-pr-review-monitor/runs/20260708_111027_pr907/codex_last_message.json' --color never - < '/tmp/ptoas-pr-review-monitor/runs/20260708_111027_pr907/review_prompt.txt'
[monitor] stage timeout: 1800s
OpenAI Codex v0.115.0 (research preview)
--------
workdir: /tmp/ptoas-pr-review-monitor/runs/20260708_111027_pr907/repo
model: gpt-5.4
provider: codereview
approval: never
sandbox: read-only
reasoning effort: xhigh
reasoning summaries: none
session id: 019f3fb4-b5ef-7323-92b7-51f6a523f639
--------
user
你现在在审查 GitHub PR。

仓库:hw-native-sys/PTOAS
PR:#907 Fix TileLang ST CI failures
作者:mouliangyu
base branch:origin/main
head branch:HEAD(当前已 checkout 到 PR head)

要求:
1. 只审查这个 PR 相对 origin/main 的改动,必要时可以看上下文文件。
2. 重点找真实的 correctness / regression / contract mismatch / CI / runtime / compatibility 问题。
3. 不要提纯风格建议,不要提低价值猜测。
4. 严格按优先级输出:
   - P1:高概率会导致错误结果、编译/运行失败、严重回归、发布阻断
   - P2:重要缺陷、行为回归、遗漏校验/测试、较大兼容性问题
   - P3:次要但明确可改的问题
5. 如果没有问题,summary 直接写:未检查到 PR #907 存在问题,并返回 findings=[]。
6. 如果有问题,summary 简洁概括,findings 里每条都要给出:
   - severity
   - title
   - body(说明为什么是问题,尽量具体)
   - file(尽量给相对路径)
   - line(能确定就填整数,否则 null)

建议先查看:
- git status --short
- git diff --stat origin/main...HEAD
- git diff --unified=80 origin/main...HEAD

最终输出必须严格匹配 JSON schema。

mcp startup: no servers
Reconnecting... 1/5 (unexpected status 403 Forbidden: {"code":"INSUFFICIENT_BALANCE","message":"Insufficient account balance"}, url: https://codex.0u0o.com/responses, cf-ray: a17be5918d21e9df-LAX, request id: 168bec94-df55-452d-8d51-7947187f833a)
Reconnecting... 2/5 (unexpected status 403 Forbidden: {"code":"INSUFFICIENT_BALANCE","message":"Insufficient account balance"}, url: https://codex.0u0o.com/responses, cf-ray: a17be594aa89cf25-SJC, request id: 28f80707-1c6b-489e-8261-aee18a1e9d40)
Reconnecting... 3/5 (unexpected status 403 Forbidden: {"code":"INSUFFICIENT_BALANCE","message":"Insufficient account balance"}, url: https://codex.0u0o.com/responses, cf-ray: a17be5a35a04fa49-SJC, request id: d0df0d11-42dc-420f-8549-205d28685dc9)
Reconnecting... 4/5 (unexpected status 403 Forbidden: {"code":"INSUFFICIENT_BALANCE","message":"Insufficient account balance"}, url: https://codex.0u0o.com/responses, cf-ray: a17be5aa78e8f317-LAS, request id: 31edb1f5-9296-4a32-8e25-2a099f8026d6)
Reconnecting... 5/5 (unexpected status 403 Forbidden: {"code":"INSUFFICIENT_BALANCE","message":"Insufficient account balance"}, url: https://codex.0u0o.com/responses, cf-ray: a17be5b75e4b4d21-SJC, request id: bd964df9-7e57-4ae4-985e-a12acf5b40e3)
ERROR: unexpected status 403 Forbidden: {"code":"INSUFFICIENT_BALANCE","message":"Insufficient account balance"}, url: https://codex.0u0o.com/responses, cf-ray: a17be5cecc201321-SJC, request id: 9a9f4494-06e8-4837-9c7b-6a274713114b
Warning: no last agent message; wrote empty content to /tmp/ptoas-pr-review-monitor/runs/20260708_111027_pr907/codex_last_message.json
===== END STAGE codex-review rc=1 @ 2026-07-08 11:10:45 =====

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants