Add patched LLVM extensions build toggle#904
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a new CMake option, PTOAS_ENABLE_PATCHED_LLVM_EXTENSIONS, which allows building code paths that depend on patched LLVM APIs. It wraps several LLVM-specific extensions, such as low-precision float types and SIMT calling conventions, in preprocessor guards across VPTOCANN900LLVMEmitter.cpp, VPTOLLVMEmitter.cpp, and VPTOLLVMEmitterHelper.cpp to ensure compatibility when these extensions are disabled. There are no review comments, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Codex Review该评论由 review 机器人自动更新。
SummaryReview failed at stage Findings未生成结构化 findings,因为 review 过程提前失败。 Log Tail |
ddb8f51 to
1b2461b
Compare
1b2461b to
7397a13
Compare
Summary
PTOAS_ENABLE_PATCHED_LLVM_EXTENSIONSCMake option, defaulting toON-DPTOAS_ENABLE_PATCHED_LLVM_EXTENSIONS=OFFValidation
cmake -S . -B .work/ptoas-build-llvm21-unpatched -DPTOAS_ENABLE_PATCHED_LLVM_EXTENSIONS=OFFcmake --build .work/ptoas-build-llvm21-unpatched -j$(nproc).work/ptoas-build-llvm21-unpatched/tools/ptoas/ptoas --version