[DreamBooth SDXL LoRA] Apply SNR min-weighting to prior preservation loss when snr_gamma is set#13797
Open
Dev-X25874 wants to merge 2 commits into
Open
Conversation
… and prior preservation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In
examples/dreambooth/train_dreambooth_lora_sdxl.py, when training withboth
--snr_gammaand--with_prior_preservation, the Min-SNR lossweighting (Section 3.4 of https://huggingface.co/papers/2303.09556) is
applied to the instance loss but silently skipped for the prior preservation
loss. The prior loss is computed before the
snr_gammabranch runs, somse_loss_weightsis never multiplied into it — the prior loss alwaysfalls back to plain MSE regardless of
--snr_gamma.This PR fixes the
snr_gammabranch to also applymse_loss_weightstoprior_loss, mirroring the same pattern already used for the instance loss.A new test covering the
--snr_gamma+--with_prior_preservationcombinationis also added to
test_dreambooth_lora.py.Fixes # (issue)
Before submitting
Who can review?
@sayakpaul