feat(tune)!: replace luminance with tint, remove sharpness, fix colorOverlay/fade#844
Merged
Conversation
…Overlay/fade - tint: new green–magenta control complementing temperature - colorOverlay: fix inverted sign (previously tinted towards the complementary color) - fade: rebuild as a real fade (lower contrast + lifted black point) instead of desaturation - remove sharpness (a per-pixel color matrix cannot sharpen) BREAKING CHANGE: renamed luminance → tint and removed sharpness across ColorFilterAddons, TuneEditorIcons and I18nTuneEditor; saved histories using the old tune ids are no longer recognized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleanup of the
ColorFilterAddonscolor matrices and the tune-editor adjustments.colorOverlay— fix inverted sign; overlays now blend towards the given color instead of its complement (affects all overlay-based filter presets).fade— rebuilt as a real fade (lower contrast + lifted black point) instead of a plain desaturation.tint(new) — replaces the oldluminancecontrol with a green–magenta adjustment, the natural complement totemperature. The previousluminancematrix only desaturated (it was a duplicate ofsaturationand never touched brightness).sharpness— removed. A per-pixel 4×5 color matrix cannot sharpen (that needs a spatial convolution); the old implementation was just a mislabeled contrast boost.Docs on
hue(rotation mapsvalue == 1to 180°) were also corrected.Breaking changes
ColorFilterAddons.luminance→tint,TuneEditorIcons.luminance→tint,I18nTuneEditor.luminance→tint.ColorFilterAddons.sharpness,TuneEditorIcons.sharpness,I18nTuneEditor.sharpness.luminance,sharpness) are no longer recognized — no import migration is included.Version bumped to
13.0.0.Notes
example/updated to match.dart analyzeoverlib+ example is clean.