Skip to content

fix(aarch64/interrupt): match against the correct exception class#2524

Merged
mkroening merged 1 commit into
hermit-os:mainfrom
cagatay-y:fix-aarch64-exception-class
Jul 3, 2026
Merged

fix(aarch64/interrupt): match against the correct exception class#2524
mkroening merged 1 commit into
hermit-os:mainfrom
cagatay-y:fix-aarch64-exception-class

Conversation

@cagatay-y

Copy link
Copy Markdown
Contributor

A mix-up seems to have happened in 341a1bf when replacing hardcoded literals with the enum variants.

A mix-up seems to have happened in 341a1bf when replacing hardcoded literals
with the enum variants.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Results

Details
Benchmark Current: 1c5da90 Previous: badd4c4 Performance Ratio
startup_benchmark Build Time 81.00 s 81.10 s 1.00
startup_benchmark File Size 0.80 MB 0.80 MB 1.00
Startup Time - 1 core 0.76 s (±0.03 s) 0.76 s (±0.03 s) 0.99
Startup Time - 2 cores 0.76 s (±0.02 s) 0.77 s (±0.02 s) 0.99
Startup Time - 4 cores 0.77 s (±0.02 s) 0.77 s (±0.02 s) 1.00
multithreaded_benchmark Build Time 83.81 s 83.97 s 1.00
multithreaded_benchmark File Size 0.90 MB 0.90 MB 1.00
Multithreaded Pi Efficiency - 2 Threads 90.33 % (±4.61 %) 89.33 % (±7.36 %) 1.01
Multithreaded Pi Efficiency - 4 Threads 43.77 % (±1.84 %) 43.68 % (±2.83 %) 1.00
Multithreaded Pi Efficiency - 8 Threads 25.25 % (±1.30 %) 25.39 % (±2.06 %) 0.99
micro_benchmarks Build Time 82.73 s 82.38 s 1.00
micro_benchmarks File Size 0.90 MB 0.90 MB 1.00
Scheduling time - 1 thread 66.18 ticks (±3.40 ticks) 67.71 ticks (±4.24 ticks) 0.98
Scheduling time - 2 threads 36.20 ticks (±3.55 ticks) 38.11 ticks (±5.12 ticks) 0.95
Micro - Time for syscall (getpid) 4.53 ticks (±0.74 ticks) 4.23 ticks (±0.74 ticks) 1.07
Memcpy speed - (built_in) block size 4096 81922.87 MByte/s (±56783.63 MByte/s) 79468.16 MByte/s (±55116.80 MByte/s) 1.03
Memcpy speed - (built_in) block size 1048576 30484.40 MByte/s (±24668.03 MByte/s) 30161.95 MByte/s (±24453.66 MByte/s) 1.01
Memcpy speed - (built_in) block size 16777216 26655.41 MByte/s (±22007.36 MByte/s) 26353.33 MByte/s (±21799.52 MByte/s) 1.01
Memset speed - (built_in) block size 4096 82111.00 MByte/s (±56899.17 MByte/s) 79293.80 MByte/s (±54991.57 MByte/s) 1.04
Memset speed - (built_in) block size 1048576 31245.49 MByte/s (±25105.37 MByte/s) 30914.27 MByte/s (±24888.27 MByte/s) 1.01
Memset speed - (built_in) block size 16777216 27433.51 MByte/s (±22502.58 MByte/s) 27104.01 MByte/s (±22268.97 MByte/s) 1.01
Memcpy speed - (rust) block size 4096 72363.48 MByte/s (±50861.69 MByte/s) 75054.08 MByte/s (±52569.58 MByte/s) 0.96
Memcpy speed - (rust) block size 1048576 30407.10 MByte/s (±24678.21 MByte/s) 30128.07 MByte/s (±24471.52 MByte/s) 1.01
Memcpy speed - (rust) block size 16777216 27681.38 MByte/s (±22882.53 MByte/s) 26810.93 MByte/s (±22268.16 MByte/s) 1.03
Memset speed - (rust) block size 4096 72830.32 MByte/s (±51203.96 MByte/s) 76095.53 MByte/s (±53191.49 MByte/s) 0.96
Memset speed - (rust) block size 1048576 31168.14 MByte/s (±25113.90 MByte/s) 30853.29 MByte/s (±24883.30 MByte/s) 1.01
Memset speed - (rust) block size 16777216 28460.64 MByte/s (±23360.16 MByte/s) 27563.43 MByte/s (±22730.99 MByte/s) 1.03
alloc_benchmarks Build Time 77.13 s 76.59 s 1.01
alloc_benchmarks File Size 0.88 MB 0.88 MB 1.00
Allocations - Allocation success 91.31 % 91.31 % 1
Allocations - Deallocation success 100.00 % 100.00 % 1
Allocations - Pre-fail Allocations 61.44 % 61.44 % 1
Allocations - Average Allocation time 5096.71 Ticks (±98.75 Ticks) 3943.99 Ticks (±137.69 Ticks) 1.29
Allocations - Average Allocation time (no fail) 5845.19 Ticks (±110.65 Ticks) 4914.38 Ticks (±99.02 Ticks) 1.19
Allocations - Average Deallocation time 1405.17 Ticks (±209.12 Ticks) 1615.85 Ticks (±252.34 Ticks) 0.87
mutex_benchmark Build Time 77.65 s 79.65 s 0.97
mutex_benchmark File Size 0.90 MB 0.90 MB 1.00
Mutex Stress Test Average Time per Iteration - 1 Threads 12.08 ns (±0.27 ns) 12.20 ns (±0.45 ns) 0.99
Mutex Stress Test Average Time per Iteration - 2 Threads 42.10 ns (±2.21 ns) 41.90 ns (±2.35 ns) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@mkroening mkroening self-assigned this Jul 3, 2026
@mkroening mkroening requested a review from Gelbpunkt July 3, 2026 17:11

@Gelbpunkt Gelbpunkt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, I'm still not sure how this came to be, I might've been staring at bits for too long when writing this :)

@mkroening mkroening added this pull request to the merge queue Jul 3, 2026
Merged via the queue into hermit-os:main with commit 8b752b3 Jul 3, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants