FE-1085: Elicitor project capability design#271
Merged
Conversation
Signed-off-by: Lu Nelson <ln@hash.ai>
Signed-off-by: Lu Nelson <ln@hash.ai>
Signed-off-by: Lu Nelson <ln@hash.ai>
Signed-off-by: Lu Nelson <ln@hash.ai>
Signed-off-by: Lu Nelson <ln@hash.ai>
Signed-off-by: Lu Nelson <ln@hash.ai>
Signed-off-by: Lu Nelson <ln@hash.ai>
Signed-off-by: Lu Nelson <ln@hash.ai>
Amp-Thread-ID: https://ampcode.com/threads/T-019f18e7-dfee-707e-8b4e-924836215180 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019f18e7-dfee-707e-8b4e-924836215180 Co-authored-by: Amp <amp@ampcode.com>
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![semgrep-code-hashintel[bot]](https://avatars.githubusercontent.com/u/22116112?s=60&v=4){kind=small}
|
Semgrep found 3 Detected a call to |
Amp-Thread-ID: https://ampcode.com/threads/T-019f1971-7e48-7080-a98b-b2639acabe23 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019f1971-7e48-7080-a98b-b2639acabe23 Co-authored-by: Amp <amp@ampcode.com>
PR SummaryLow Risk Overview Repoints authority for Pi-seam and runtime truth: Rewrites Updates the live ship runbook so steps 7–8 prove Specify ↔ Execute mode switching (not strategy/lens posture), with artifacts/checks renamed ( Reviewed by Cursor Bugbot for commit e285741. Bugbot is set up for automated code reviews on this repo. Configure here. |
lunelson
changed the title
There was a problem hiding this comment.
Pull request overview
This PR consolidates Brunch’s “manual skill + prompt” surfaces by retiring the legacy strategy/lens/method runtime axes, introducing a code-owned first-level live skill registry, and relocating shared static references into a single runtime-eligible home.
Changes:
- Remove legacy runtime axis fields (strategy/lens/freestyle) from session state, assistant-turn origination decisions, probes, and tests.
- Add a code-owned live skill manifest (
src/agents/skills/registry.ts) and inject the live-skill list into composed foreground/background prompts. - Retire generated ontology reference + associated scripts/tests; replace with authored reference docs under
src/agents/references/.
Reviewed changes
Copilot reviewed 158 out of 160 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/session/start-assistant-turn.ts | Drops strategy input and explicit_freestyle idle reason |
| src/session/schema/TOPOLOGY.md | Updates session schema ownership notes after axis retirement |
| src/session/schema/kinds.ts | Removes legacy axis enums; adds operational-mode labels/helper |
| src/session/schema/agent-manifest.ts | Simplifies agent manifest skills typing to string list |
| src/session/runtime-state.ts | Removes strategy/lens from persisted runtime-state schema |
| src/session/originate-assistant-turn.ts | Removes strategy plumbing; simplifies skip-reason mapping |
| src/session/tests/start-assistant-turn.test.ts | Updates tests for removed freestyle/strategy behavior |
| src/session/tests/originate-assistant-turn.test.ts | Removes explicit-freestyle skip outcome coverage |
| src/session/tests/jsonl-session-viability.test.ts | Switches viability matrix away from brunch.lens_switch |
| src/rpc/TOPOLOGY.md | Removes strategy/lens metadata mention from toolResult shape |
| src/rpc/tests/handlers.test.ts | Updates fixture runtime state to omit legacy axis fields |
| src/projections/session/tests/runtime-state.test.ts | Ensures projection ignores stale legacy fields; mode drives role |
| src/probes/propose-graph-commit-proof.ts | Removes legacy axis fields from probe runtime state |
| src/probes/project-graph-review-cycle-proof.ts | Removes legacy axis fields from probe + report type |
| src/probes/fixture-curation-loop.ts | Removes legacy axis fields from probe + report type |
| src/probes/tests/project-graph-review-cycle-proof.test.ts | Updates test runtimeState fixture to omit legacy fields |
| src/probes/tests/fixture-curation-loop.test.ts | Updates test runtimeState fixture to omit legacy fields |
| src/graph/TOPOLOGY.md | Removes generated ontology reference mechanism description |
| src/graph/schema/tests/generate-ontology-ref.test.ts | Deletes ontology generator drift-guard test |
| src/dev/generate-fan-out-witness.ts | Updates witness markers from generate-proposal → propose |
| src/dev/tests/tier-2-harness.test.ts | Removes lens command assertions; uses mode switch instead |
| src/dev/tests/faux-harness.test.ts | Expects <brunch-skills> to be present in composed prompt |
| src/app/pi-extensions.ts | Removes exports for retired lens/strategy commands |
| src/app/brunch-tui.ts | Stops deriving assistant-turn strategy from runtime state |
| src/app/tests/brunch-tui.test.ts | Updates command registry expectations (mode-only) |
| src/agents/TOPOLOGY.md | Rehomes references under agents/references/; updates boundary rules |
| src/agents/subagents/TOPOLOGY.md | Clarifies projector as background helper, not public “project” seam |
| src/agents/subagents/projector.md | Updates projector description and constraints wording |
| src/agents/skills/tutorial/SKILL.md | Adds first-level tutorial skill stub |
| src/agents/skills/synthesis/SKILL.md | Removes old synthesize skill (replaced by analyze) |
| src/agents/skills/review/SKILL.md | Expands review procedure + plane heuristics |
| src/agents/skills/registry.ts | Adds code-owned live skill registry + manifest renderer |
| src/agents/skills/propose/SKILL.md | Adds first-level propose skill and shared generate spine |
| src/agents/skills/propose/references/present-review-set.md | Adds propose-local review-set drafting reference |
| src/agents/skills/propose/references/oracle.md | Adds oracle proposal reference |
| src/agents/skills/propose/references/intent.md | Adds intent proposal reference |
| src/agents/skills/propose/references/design.md | Adds design proposal reference |
| src/agents/skills/projection/SKILL.md | Removes old projection skill (superseded by project / propose) |
| src/agents/skills/projection/references/review-set-drafting.md | Removes old projection review-set drafting reference |
| src/agents/skills/project/SKILL.md | Adds first-level project skill |
| src/agents/skills/project/references/intent-to-design.md | Adds intent→design projection lane reference |
| src/agents/skills/project/references/design-to-oracle.md | Adds design→oracle projection lane reference |
| src/agents/skills/map/references/routing.md | Adds explicit routing guidance (truth/advisory/gap/reconciliation/review) |
| src/agents/skills/map/references/map-plans.md | Renames/retitles to mapping language |
| src/agents/skills/map/references/map-oracles.md | Renames/retitles to mapping language |
| src/agents/skills/map/references/map-nodes.md | Adds consolidated node-kind classification reference |
| src/agents/skills/map/references/map-detail-payloads.md | Updates detail-payload reference to cite schema source directly |
| src/agents/skills/map/references/map-design.md | Renames/retitles to mapping language |
| src/agents/skills/ingest/TOPOLOGY.md | Adds topology file for ingest skill subtree |
| src/agents/skills/elicitation/SKILL.md | Removes old elicitation skill (replaced by elicit) |
| src/agents/skills/elicit/SKILL.md | Adds first-level elicit skill |
| src/agents/skills/capture/TOPOLOGY.md | Removes capture TOPOLOGY (and associated slice drafts) |
| src/agents/skills/capture/slice-promotion-capture.md | Deletes capture slice draft |
| src/agents/skills/capture/slice-kind-selection.md | Deletes capture slice draft |
| src/agents/skills/capture/slice-edge-authoring.md | Deletes capture slice draft |
| src/agents/skills/capture/slice-band-walk.md | Deletes capture slice draft |
| src/agents/skills/capture/SKILL.md | Deletes old capture skill stub |
| src/agents/skills/capture/skill-ingest.md | Deletes old ingest draft in capture subtree |
| src/agents/skills/capture/references/readiness-bands.md | Deletes old readiness-bands reference (moved to agents/references) |
| src/agents/skills/capture/references/intent-capture.md | Deletes old intent-capture reference |
| src/agents/skills/capture/references/edge-heuristics.md | Deletes old edge-heuristics reference |
| src/agents/skills/analyze/SKILL.md | Adds first-level analyze skill (replaces synthesize/read-context) |
| src/agents/skills/analyze/references/neighborhoods.md | Adds neighborhood consumption reference under analyze |
| src/agents/skills/_suspended/TOPOLOGY.md | Deletes suspended skills taxonomy TOPOLOGY |
| src/agents/skills/_suspended/strategies/TOPOLOGY.md | Deletes suspended strategies TOPOLOGY |
| src/agents/skills/_suspended/strategies/step-wise-disambiguate/SKILL.md | Deletes suspended strategy skill |
| src/agents/skills/_suspended/strategies/step-wise-decision-tree/SKILL.md | Deletes suspended strategy skill |
| src/agents/skills/_suspended/strategies/freestyle/SKILL.md | Deletes suspended freestyle strategy skill |
| src/agents/skills/_suspended/methods/run-structured-exchange/SKILL.md | Deletes suspended method skill |
| src/agents/skills/_suspended/methods/review-for-gaps/SKILL.md | Deletes suspended method skill |
| src/agents/skills/_suspended/methods/read-referenced-documents/SKILL.md | Deletes suspended method skill |
| src/agents/skills/_suspended/methods/read-context/SKILL.md | Deletes suspended method skill |
| src/agents/skills/_suspended/methods/ingest-paste/SKILL.md | Deletes suspended method skill |
| src/agents/skills/_suspended/methods/generate-proposal/SKILL.md | Deletes suspended generate-proposal method skill |
| src/agents/skills/_suspended/methods/generate-proposal/references/oracle.md | Deletes suspended reference |
| src/agents/skills/_suspended/methods/generate-proposal/references/intent.md | Deletes suspended reference |
| src/agents/skills/_suspended/methods/generate-proposal/references/design.md | Deletes suspended reference |
| src/agents/skills/_suspended/methods/generate-proposal/probes.md | Deletes suspended probes doc |
| src/agents/skills/_suspended/methods/explore-and-characterize/SKILL.md | Deletes suspended method skill |
| src/agents/skills/_suspended/methods/elicit-by-question/SKILL.md | Deletes suspended method skill |
| src/agents/skills/_suspended/methods/commit-graph/SKILL.md | Deletes suspended method skill |
| src/agents/skills/_suspended/lenses/TOPOLOGY.md | Deletes suspended lenses TOPOLOGY |
| src/agents/skills/_suspended/lenses/oracle/SKILL.md | Deletes suspended lens skill |
| src/agents/skills/_suspended/lenses/intent/SKILL.md | Deletes suspended lens skill |
| src/agents/skills/_suspended/lenses/design/SKILL.md | Deletes suspended lens skill |
| src/agents/skills/fixtures/unlisted-fixture/SKILL.md | Removes fixture for ambient-discovery non-advertising |
| src/agents/runtime/TOPOLOGY.md | Updates runtime topology; removes suspended subtree mention |
| src/agents/runtime/shared/TOPOLOGY.md | Updates shared runtime boundary notes |
| src/agents/runtime/executor/TOPOLOGY.md | Updates executor boundary notes (no suspended policy) |
| src/agents/runtime/executor/compose-prompt.ts | Appends live skill manifest to executor prompt |
| src/agents/runtime/elicitor/TOPOLOGY.md | Updates elicitor boundary notes (no suspended policy) |
| src/agents/runtime/elicitor/compose-live-prompt.ts | Appends live skill manifest to elicitor prompt |
| src/agents/runtime/elicitor/snapshots/live-elicitor-prompt.md | Updates prompt snapshot with <brunch-skills> block |
| src/agents/runtime/_suspended/TOPOLOGY.md | Deletes suspended runtime control TOPOLOGY |
| src/agents/runtime/_suspended/prompt-skills.ts | Deletes suspended prompt-skills renderer |
| src/agents/runtime/_suspended/capability-readiness.ts | Deletes suspended capability readiness logic |
| src/agents/runtime/_suspended/tests/runtime-affordances-coverage.test.ts | Deletes suspended affordance coverage test |
| src/agents/runtime/_suspended/tests/policy.test.ts | Deletes suspended policy test |
| src/agents/references/TOPOLOGY.md | Adds new static reference home documentation |
| src/agents/references/product-concept.md | Updates product concept to match new model framing |
| src/agents/references/node-neighbourhoods.md | Rehomes/retitles neighborhood guidance |
| src/agents/references/data-model.md | Adds authored data-model reference (replacing generated ontology ref) |
| src/agents/prompts/TOPOLOGY.md | Updates prompt topology ownership wording |
| src/agents/prompts/executor.md | Updates link target to new reference home |
| src/agents/prompts/elicitor.md | Updates elicitor operating loop guidance and tool naming |
| src/agents/prompts/tests/registry.test.ts | Asserts project is listed as live first-level skill |
| src/agents/contexts/TOPOLOGY.md | Moves “static references” ownership to agents/references |
| src/agents/contexts/seeds/turn-context.ts | Removes lens selection import; uses local GraphSeedLens |
| src/agents/contexts/references/graph-ontology.md | Deletes generated ontology reference |
| src/agents/contexts/about/elicitation-stage-eval.md | Deletes legacy about doc |
| src/agents/contexts/about/elicitation-lifecycle.md | Deletes legacy about doc |
| src/agents/contexts/_suspended/TOPOLOGY.md | Deletes suspended contexts TOPOLOGY |
| src/.pi/extensions/subagents/prompt-assembly.ts | Appends live skill manifest to background prompts |
| src/.pi/extensions/subagents/agents.ts | Simplifies subagent manifest skills shape |
| src/.pi/extensions/compaction/index.ts | Removes lens-switch anchor requirement; updates rationale |
| src/.pi/extensions/tests/registry.test.ts | Updates expected commands/shortcuts after axis retirement |
| src/.pi/extensions/tests/chrome.test.ts | Updates chrome projection fixtures (no legacy fields) |
| src/.pi/extensions/tests/brunch-data-context.test.ts | Updates context tool fixtures (no legacy fields) |
| src/.pi/extensions/tests/agent-runtime-system-prompts.test.ts | Updates prompt-pack topology tests after axis retirement |
| src/.pi/extensions/snapshots/subagent-explorer-prompt.md | Updates subagent prompt snapshot with <brunch-skills> |
| src/.pi/components/runtime-posture/strategy-picker.ts | Removes strategy picker component export |
| README.md | Clarifies mixed-status Pi seam doc authority |
| package.json | Removes data-model check scripts; updates pi-assets build copy list |
| memory/cards/orchestrator-tool-port--plan-check-tool.md | Updates references to runtime topology after _suspended retirement |
| docs/README.md | Clarifies mixed-status architecture doc authority |
| docs/design/ONTOLOGY_REVIEW_PROTOCOL.md | Updates heuristic reference pointer |
| docs/architecture/poc-live-ship-runbook.md | Updates runbook from posture-switch to mode-switch |
| CONTRIBUTING.md | Clarifies mixed-status architecture doc authority |
| AGENTS.md | Adds rule limiting new TOPOLOGY nesting depth |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack Context
This stack completes the current elicitor capability spine before the next gap-guidance frontier: first canonicalize the live SPEC-mode skill surface around
capture/generate/project, then harden the structured-exchange affordances that those skills use.What?
analyze,elicit,ingest,map,project,propose,review,tutorial) plus shared graph/reference material.projectas a first-level SPEC-mode capability for cross-plane derivation from accepted graph anchors.Why?
projectwas the remaining capability implied by the elicitor spine, but treating it as ageneratesub-mode would blur two different jobs: generating alternatives within one plane vs. deriving downstream plane material from accepted upstream graph truth. This PR givesprojectits own prompt-resource home while keeping it on the existing exchange/review-set seams—no new product tool, schema family, or direct graph-write path.