feat(harness): rail only #216
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,10 +31,12 @@ import { Button } from "@opencode-ai/ui/button" | |
| import { Card } from "@opencode-ai/ui/card" | ||
| import { | ||
| ContextToolGroup, | ||
| EditToolGroup, | ||
| Message, | ||
| MessageDivider, | ||
| Part as MessagePart, | ||
| partDefaultOpen, | ||
| ShellToolGroup, | ||
| type UserActions, | ||
| } from "@opencode-ai/session-ui/message-part" | ||
| import { DiffChanges } from "@opencode-ai/ui/diff-changes" | ||
|
|
@@ -1396,6 +1398,115 @@ export function MessageTimeline(props: { | |
| </TimelineRowFrame> | ||
| ) | ||
| } | ||
| case "StepFrame": { | ||
| const stepFrameRow = row as Accessor<TimelineRowByTag<"StepFrame">> | ||
| const frame = () => stepFrameRow() | ||
| const isRunning = () => frame().state === "running" | ||
| const isError = () => frame().state === "error" | ||
| const dotActive = () => isRunning() && frame().lastStep | ||
| return ( | ||
| <TimelineRowFrame row={stepFrameRow as unknown as Accessor<FramedTimelineRow>}> | ||
| <div data-slot="session-turn-message-container" class="w-full px-3 md:px-4 min-w-0 overflow-hidden"> | ||
| <div | ||
| data-slot="harness-step-frame" | ||
| data-state={frame().state} | ||
| data-step-index={frame().stepIndex} | ||
| class="relative pl-4 border-l min-w-0 max-w-full overflow-hidden break-words transition-colors" | ||
| style={{ | ||
| "border-color": isError() ? "var(--v2-state-border-danger)" : isRunning() ? "var(--accent-edge)" : "var(--v2-text-text-base)", | ||
| }} | ||
| > | ||
| <span | ||
| data-slot="harness-step-dot" | ||
| data-active={dotActive() ? "true" : undefined} | ||
| class="absolute -left-[6px] top-[14px] size-2.5 rounded-full border-2 shrink-0" | ||
| style={{ | ||
| "border-color": isError() ? "var(--v2-state-fg-danger)" : dotActive() ? "var(--accent-fill-strong)" : "var(--v2-text-text-base)", | ||
| background: dotActive() ? "var(--accent-fill-strong)" : "transparent", | ||
| }} | ||
| /> | ||
| <div class="flex items-center gap-2 py-1.5 min-w-0"> | ||
| <span class="text-[11px] font-medium tracking-wide text-v2-text-text-faint shrink-0">Step {frame().stepIndex + 1}</span> | ||
| <span class="text-[11px] text-v2-text-text-muted truncate min-w-0"> | ||
| {frame().reasoningHeading ? frame().reasoningHeading : frame().groups.length === 1 && frame().groups[0]?.type === "part" ? "response" : `${frame().groups.length} groups`} | ||
| </span> | ||
|
|
||
| </div> | ||
| <Show when={frame().reasoningHeading}> | ||
| <div class="pb-2 text-[12px] italic leading-5 text-v2-text-text-muted break-words whitespace-normal max-w-full overflow-hidden">{frame().reasoningHeading}</div> | ||
| </Show> | ||
| <div class="flex flex-col gap-1.5 pb-3 min-w-0 max-w-full overflow-hidden"> | ||
| <For each={frame().groups}> | ||
| {(group) => { | ||
| if (group.type === "context") { | ||
| const parts = () => | ||
| group.refs | ||
| .map((ref) => getMsgPart(ref.messageID, ref.partID)) | ||
| .filter((p): p is ToolPart => p?.type === "tool") | ||
| const key = () => `context:${group.key}` | ||
| const open = () => toolOpen[key()] === true | ||
| return ( | ||
| <ContextToolGroup | ||
| parts={parts()} | ||
| open={open()} | ||
| onOpenChange={(v) => setToolOpen(key(), v)} | ||
| busy={workingTurn(frame().userMessageID) && frame().state === "running"} | ||
| onSizeChange={onSizeChange} | ||
| /> | ||
| ) | ||
| } | ||
| if (group.type === "shell") { | ||
| const parts = () => | ||
| group.refs | ||
| .map((ref) => getMsgPart(ref.messageID, ref.partID)) | ||
| .filter((p): p is ToolPart => p?.type === "tool") | ||
| return <ShellToolGroup parts={parts()} busy={workingTurn(frame().userMessageID) && frame().state === "running"} onSizeChange={onSizeChange} /> | ||
| } | ||
| if (group.type === "edit") { | ||
| const parts = () => | ||
| group.refs | ||
| .map((ref) => getMsgPart(ref.messageID, ref.partID)) | ||
| .filter((p): p is ToolPart => p?.type === "tool") | ||
| return <EditToolGroup parts={parts()} busy={workingTurn(frame().userMessageID) && frame().state === "running"} onSizeChange={onSizeChange} /> | ||
| } | ||
|
Comment on lines
+1438
to
+1471
There was a problem hiding this comment. 🩺 Stability & Availability | 🟠 Major | 🏗️ Heavy lift 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Confirm ShellToolGroup and EditToolGroup expose no controlled open prop.
set -euo pipefail
ast-grep run --pattern 'export function ShellToolGroup($_) { $$$ }' --lang tsx packages/session-ui/src/components/message-part.tsx | head -40
ast-grep run --pattern 'export function EditToolGroup($_) { $$$ }' --lang tsx packages/session-ui/src/components/message-part.tsx | head -40Repository: harmoniqs/opencode Length of output: 7870 🏁 Script executed: #!/bin/bash
set -euo pipefail
printf '%s\n' '--- timeline group rendering ---'
sed -n '1400,1490p' packages/app/src/pages/session/timeline/message-timeline.tsx
printf '%s\n' '--- groupParts and projection callers ---'
rg -n -C 12 'groupParts|frame\(\)\.groups|PartGroup' packages/app/src/pages/session/timeline packages -g '*.ts' -g '*.tsx' | head -240
printf '%s\n' '--- relevant package versions and For implementation references ---'
rg -n '"solid-js"|<For|<Index|function For|const For' package.json packages/*/package.json packages/app packages/session-ui -g '*.json' -g '*.ts' -g '*.tsx' | head -200Repository: harmoniqs/opencode Length of output: 50374 🏁 Script executed: #!/bin/bash
set -euo pipefail
printf '%s\n' '--- StepFrame construction and row reconciliation ---'
sed -n '160,225p' packages/app/src/pages/session/timeline/rows.ts
fd -i 'row-reconciliation' packages/app/src/pages/session/timeline --type f --exec sh -c 'echo "--- $1"; cat -n "$1"' sh {} \;
rg -n -C 8 'constructSessionMessageRows|reuseTimelineRows|row\(\)|set.*rows|rows\(' packages/app/src/pages/session/timeline packages/app/src/pages/session -g '*.ts' -g '*.tsx' | head -240
printf '%s\n' '--- groupParts implementation and PartGroup identity fields ---'
rg -n -C 30 'function groupParts|export function groupParts|type PartGroup|interface PartGroup' packages/session-ui/src/components/message-part.tsx packages/session-ui/src -g '*.ts' -g '*.tsx' | head -240Repository: harmoniqs/opencode Length of output: 50374 🏁 Script executed: #!/bin/bash
set -euo pipefail
printf '%s\n' '--- all row-reconciliation callers ---'
rg -n -C 15 'reuseTimelineRows' packages/app/src -g '*.ts' -g '*.tsx'
printf '%s\n' '--- TimelineRow equality and key logic ---'
rg -n -C 20 'export namespace TimelineRow|function equals|equals\(|function key|key\(' packages/app/src/pages/session/timeline/timeline-row.ts packages/app/src/pages/session/timeline -g '*.ts' | head -220
printf '%s\n' '--- focused groupParts remainder ---'
sed -n '78,190p' packages/session-ui/src/components/message-part-groups.ts
printf '%s\n' '--- StepFrame type and row projection types ---'
rg -n -C 12 'StepFrame|timelineRowByKey|TimelineRowView|constructSessionMessageRows' packages/app/src/pages/session/timeline/message-timeline.tsx packages/app/src/pages/session/timeline -g '*.ts' -g '*.tsx' | head -220Repository: harmoniqs/opencode Length of output: 50374 🏁 Script executed: #!/bin/bash
set -euo pipefail
python3 - <<'PY'
from pathlib import Path
source = Path("packages/session-ui/src/components/message-part-groups.ts").read_text()
timeline = Path("packages/app/src/pages/session/timeline/message-timeline.tsx").read_text()
checks = {
"groupParts creates a fresh result array": "const result: PartGroup[] = []" in source,
"groupParts creates fresh group objects": "result.push({" in source and "refs: slice.map" in source,
"StepFrame calls groupParts": "const groups = groupParts(" in Path("packages/app/src/pages/session/timeline/rows.ts").read_text(),
"shell group has no controlled open prop": "export function ShellToolGroup(props: { parts: ToolPart[]; busy?: boolean; onSizeChange?: () => void })" in Path("packages/session-ui/src/components/message-part.tsx").read_text(),
"edit group has no controlled open prop": "export function EditToolGroup(props: { parts: ToolPart[]; busy?: boolean; onSizeChange?: () => void })" in Path("packages/session-ui/src/components/message-part.tsx").read_text(),
"StepFrame uses For": "<For each={frame().groups}>" in timeline,
"proposed Index branch snapshots the accessor": "const group = groupAccessor()" in timeline,
}
for name, value in checks.items():
print(f"{name}: {'yes' if value else 'no'}")
# Show whether the proposed Index callback reads the accessor only in the
# callback body, rather than using it in a reactive JSX expression.
start = timeline.index("<For each={frame().groups}>")
end = timeline.index("</For>", start)
block = timeline[start:end]
print("proposed Index callback uses groupAccessor() in branch selection:",
"const group = groupAccessor()" in block)
PYRepository: harmoniqs/opencode Length of output: 511 🌐 Web query:
💡 Result: In SolidJS 1.9, the Citations:
Preserve shell and edit expansion state across streaming group changes. When a tool is appended, 🤖 Prompt for AI Agents |
||
| const msg = () => messageByID().get(group.ref.messageID) | ||
| const part = () => getMsgPart(group.ref.messageID, group.ref.partID) | ||
| const defaultOpen = () => { | ||
| const item = part() | ||
| if (!item) return | ||
| return partDefaultOpen(item, settings.general.shellToolPartsExpanded(), settings.general.editToolPartsExpanded()) | ||
| } | ||
| return ( | ||
| <Show when={msg()}> | ||
| {(message) => ( | ||
| <Show when={part()}> | ||
| {(part) => ( | ||
| <MessagePart | ||
| part={part()} | ||
| message={message()} | ||
| showAssistantCopyPartID={assistantCopyPartID(frame().userMessageID)} | ||
| turnDurationMs={turnDurationMs(frame().userMessageID)} | ||
| useV2Actions={settings.general.newLayoutDesigns()} | ||
| defaultOpen={defaultOpen()} | ||
| toolOpen={toolOpen[part().id] ?? defaultOpen()} | ||
| onToolOpenChange={(open) => setToolOpen(part().id, open)} | ||
| deferToolContent | ||
| virtualizeDiff={false} | ||
| onContentRendered={onSizeChange} | ||
| /> | ||
| )} | ||
| </Show> | ||
| )} | ||
| </Show> | ||
| ) | ||
| }} | ||
| </For> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </TimelineRowFrame> | ||
| ) | ||
| } | ||
| case "Thinking": { | ||
| const thinkingRow = row as Accessor<TimelineRowByTag<"Thinking">> | ||
| return ( | ||
|
|
@@ -2067,6 +2178,7 @@ export function MessageTimeline(props: { | |
| )} | ||
| </Show> | ||
| </div> | ||
|
|
||
| {/* amicode: problem-header rail (renders only when the session has | ||
| amicode_* parts) + ask/ui bridges — ported from the pre-merge | ||
| message-timeline (AMICODE-PATCHES.md "Upstream sync 2026-08-01") */} | ||
|
|
@@ -2171,6 +2283,7 @@ export function MessageTimeline(props: { | |
| </Show> | ||
| </div> | ||
| </Show> | ||
|
|
||
| {/* amicode#271: no-header fallback (new untitled sessions only) */} | ||
| <Show when={!showHeader() && activeBubble()}> | ||
| {(_) => { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
The
busyflag marks every group in a running step as active.workingTurn(frame().userMessageID) && frame().state === "running"is the same value for all groups in the frame.ContextToolGroup,ShellToolGroup, andEditToolGrouptreatbusyas pending and render the active title, for example "Gathering context" and "Working in shell". Groups that already completed inside the running step keep the active title until the turn ends.The legacy path at Line 1215 restricts
busyto the last group of the turn. Apply the same restriction here, for example by marking only the last group of the last step.Also applies to: 1463-1463, 1470-1470
🤖 Prompt for AI Agents