Skip to content

feat(onboarding): collection Stages 5-7 + handoff (Stage 8) - #445

Merged
jeonghun-jj-lee merged 1 commit into
mainfrom
jeonghun-jj-lee/438-collection-handoff
Aug 19, 2026
Merged

feat(onboarding): collection Stages 5-7 + handoff (Stage 8)#445
jeonghun-jj-lee merged 1 commit into
mainfrom
jeonghun-jj-lee/438-collection-handoff

Conversation

@jeonghun-jj-lee

@jeonghun-jj-lee jeonghun-jj-lee commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Summary

Implements #438 — the final slice completing the onboarding flow. Adds collection stages (environment, devices, goals) with seed pre-fill, and the intent-based handoff routing.

What's included

  • src/handoff_routing.ts:

    • resolveHandoffAction(intents): table-driven routing by intent selections (research → pulse-designer, general → normal-session, exploring → tour, combos)
    • resolvePreFills(state): seed-based confirmation prompts for Stages 5-6
    • readIntentFromState(profile): parse intent array from events stream
  • scores/overture/SCORE.md — now complete with all 8 stages:

    1. orientation (name)
    2. intent (multi-select)
    3. context_seed (opt-in scan)
    4. demo (Julia gate showcase)
    5. environment (with seed pre-fill)
    6. devices (optional, with seed pre-fill)
    7. goals (free-text)
    8. handoff (onboarding_completed + intent routing)

Acceptance Criteria coverage

AC Status
1. Seed pre-fill for environment Tested
2. Seed pre-fill for devices Tested
3. Goals as free-text In score
4. appendOnboardingEvent for all In score instructions
5. onboarding_completed at Stage 8 In score
6. Handoff routing table (all 7 combos) Tested
7. Seed rejection (last-write-wins) Tested
8. Score complete (all 8 stages) Tested
9. Subsequent sessions skip overture Existing predicate unchanged

Tests

19 new tests in test/handoff_routing.test.ts + updated overture_rewrite tests.

Closes #438

Summary by CodeRabbit

  • New Features

    • Expanded onboarding with environment, device, and personal-goal steps.
    • Added intent-based handoffs to guide people to the pulse designer, a standard session, or an orientation tour.
    • Added support for pre-filling environment and device details from previously recorded information.
    • Added confirmations and skip options throughout the onboarding flow.
  • Bug Fixes

    • Improved handling of incomplete or invalid intent information.
    • Ensured onboarding completion is recorded consistently.

- Handoff routing: resolveHandoffAction (intent-based), resolvePreFills
  (seed confirmation), readIntentFromState
- Overture SCORE.md complete: all 8 stages defined end-to-end
  (orientation → intent → context_seed → demo → environment → devices →
  goals → handoff)
- Stage 5-6: pre-fill from seeds with confirmation prompt
- Stage 7: free-text goals
- Stage 8: onboarding_completed marker + intent-based routing to
  pulse-designer / normal-session / tour
- Golden parity regenerated
- Existing overture_rewrite tests updated for complete stage set
- 19 new handoff routing tests (table-driven intent combinations)
@jeonghun-jj-lee
jeonghun-jj-lee marked this pull request as ready for review August 19, 2026 19:45
@jeonghun-jj-lee
jeonghun-jj-lee merged commit 586747c into main Aug 19, 2026
5 of 6 checks passed
@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b1351923-02c3-4148-bc55-0fa6532236f3

📥 Commits

Reviewing files that changed from the base of the PR and between 6502434 and 24709dc.

📒 Files selected for processing (5)
  • packages/extension/scores/overture/SCORE.md
  • packages/extension/src/handoff_routing.ts
  • packages/extension/test/handoff_routing.test.ts
  • packages/extension/test/scores/golden/compile-chained.md
  • packages/extension/test/scores/overture_rewrite.test.ts

📝 Walkthrough

Walkthrough

The Overture onboarding score now collects environment, device, and goal data after the demo. It records completion at handoff and routes to pulse design, a normal session, or an exploration tour based on recorded intent.

Changes

Overture onboarding

Layer / File(s) Summary
Intent routing and seed pre-fill
packages/extension/src/handoff_routing.ts, packages/extension/test/handoff_routing.test.ts
Adds typed routing actions, seed-based environment and device pre-fill resolution, profile intent parsing, safe defaults, and unit coverage.
Collection stages and handoff wiring
packages/extension/scores/overture/SCORE.md, packages/extension/test/scores/golden/compile-chained.md
Adds environment, optional device, goals, and handoff stages. The flow records completion and routes by intent.
Compiled score validation
packages/extension/test/scores/overture_rewrite.test.ts
Validates all eight stages and the onboarding_completed marker while excluding obsolete stages.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant OvertureScore
  participant ProfileState
  participant HandoffRouting
  participant PulseDesigner
  participant NormalSession
  OvertureScore->>ProfileState: Read recorded intent
  OvertureScore->>HandoffRouting: Resolve intent and seed values
  HandoffRouting-->>OvertureScore: Return handoff action
  OvertureScore->>PulseDesigner: Start research flow
  OvertureScore->>NormalSession: Start coding or exploration flow
Loading

Possibly related issues

  • harmoniqs/amicode#435 — This PR implements the subsequent Overture stages and intent-based handoff described by the issue.

Possibly related PRs

Suggested reviewers: aarontrowbridge

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jeonghun-jj-lee/438-collection-handoff

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Collection stages 5–7 + handoff (Stage 8): seed pre-fill and intent routing

1 participant