Rename RxSharp to ReactiveExtensionsSharp (namespace, assembly, and project files) - #4
Merged
Merged
Conversation
The published NuGet package has always been ReactiveExtensionsSharp (RxSharp itself was taken), but the assembly and every namespace stayed RxSharp - meaning what you install and what you `using` never matched. That's the exact kind of mismatch this project exists to eliminate elsewhere (see the recent Extras -> RxExtensions consolidation), so it shouldn't tolerate one at its own root. Renamed everything to line up: src/RxSharp -> src/ReactiveExtensionsSharp (and its .csproj), test/RxSharp.Tests -> test/ReactiveExtensionsSharp.Tests (and its .csproj), RxSharp.sln -> ReactiveExtensionsSharp.sln, every `namespace`/`using RxSharp*` becomes `ReactiveExtensionsSharp*`, plus matching updates to the publish workflow, docfx config, README, and CLAUDE.md. No AssemblyName/RootNamespace override needed - both already defaulted from the .csproj file name, so renaming the file was enough to produce ReactiveExtensionsSharp.dll directly. This breaks every existing `using RxSharp;` at every consumer, hence the 0.2.0 bump rather than another 0.1.x patch. All 840 tests pass, all three TFMs build clean, `dotnet format --verify-no-changes` is clean, and the assembly is still correctly strong-name signed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K92eapPm8e7mX7puT4cF4s
kblok
added a commit
to hardkoded/puppeteer-sharp
that referenced
this pull request
Jul 29, 2026
The library's namespace now matches what we've been installing all along (ReactiveExtensionsSharp - see hardkoded/ReactiveExtensions-Sharp#4 for why). Purely mechanical: using RxSharp* -> using ReactiveExtensionsSharp* in the three files that reference it, plus the package reference bump. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K92eapPm8e7mX7puT4cF4s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The published NuGet package has always been
ReactiveExtensionsSharp(RxSharpitself was taken), but the assembly and every namespace stayedRxSharp— what you install and what youusingnever matched. That's the exact kind of mismatch this project exists to eliminate elsewhere (see the recentExtras→RxExtensionsconsolidation, itself now caught up in this rename too), so it shouldn't tolerate one at its own root.Renamed everything to line up:
src/RxSharp→src/ReactiveExtensionsSharp(and its.csproj)test/RxSharp.Tests→test/ReactiveExtensionsSharp.Tests(and its.csproj)RxSharp.sln→ReactiveExtensionsSharp.slnnamespace/using RxSharp*→ReactiveExtensionsSharp*No
AssemblyName/RootNamespaceoverride needed — both already defaulted from the.csprojfile name, so renaming the file was enough to produceReactiveExtensionsSharp.dlldirectly.This breaks every existing
using RxSharp;at every consumer, hence 0.2.0 rather than another 0.1.x patch.All 840 tests pass, all three TFMs build clean,
dotnet format --verify-no-changesis clean, and the assembly is still correctly strong-name signed.🤖 Generated with Claude Code
https://claude.ai/code/session_01K92eapPm8e7mX7puT4cF4s