Skip to content

fix(metadata): mark the SHEET/SHEETS argument as optional #1717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sequba wants to merge 1 commit into
base: develop
Choose a base branch
from
+3 −2
Draft

fix(metadata): mark the SHEET/SHEETS argument as optional #1717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

### Fixed

- Fixed the `SHEET` and `SHEETS` functions declaring their single argument as required, while both accept a zero-argument call.
- Fixed the behavior of `MATCH`, `VLOOKUP`, `HLOOKUP`, and `XLOOKUP` functions when the search range contained empty cells. [#1697](https://github.com/handsontable/hyperformula/pull/1697)
- Fixed the `VLOOKUP`, `HLOOKUP`, and `XLOOKUP` functions to return `0` instead of an empty value when the matched cell in the result range is empty. [#1697](https://github.com/handsontable/hyperformula/pull/1697)
- Fixed the page freezing when entering a long string of digits containing a non-digit character near the end (e.g. `012...789a` or `012...789 123`) into a cell. [#1520](https://github.com/handsontable/hyperformula/issues/1520)
Expand Down
4 changes: 2 additions & 2 deletions src/interpreter/plugin/InformationPlugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,15 +137,15 @@ export class InformationPlugin extends FunctionPlugin implements FunctionPluginT
'SHEET': {
method: 'sheet',
parameters: [
{argumentType: FunctionArgumentType.STRING}
{argumentType: FunctionArgumentType.STRING, optionalArg: true}
],
doesNotNeedArgumentsToBeComputed: true,
vectorizationForbidden: true,
},
'SHEETS': {
method: 'sheets',
parameters: [
{argumentType: FunctionArgumentType.STRING}
{argumentType: FunctionArgumentType.STRING, optionalArg: true}
],
doesNotNeedArgumentsToBeComputed: true,
vectorizationForbidden: true,
Expand Down
Loading