Updates to throughput_qos.py #283
Open
a-gavin wants to merge 8 commits into
Open
Conversation
…rintouts Signed-off-by: Alex Gavin <alex.gavin@candelatech.com>
Signed-off-by: Alex Gavin <alex.gavin@candelatech.com>
Signed-off-by: Alex Gavin <alex.gavin@candelatech.com>
Some minor help printout adjustments Signed-off-by: Alex Gavin <alex.gavin@candelatech.com>
Signed-off-by: Alex Gavin <alex.gavin@candelatech.com>
Perhaps these can be relaxed in the future if we use the already present generic SSID, security, and passord arguments that are already present... Signed-off-by: Alex Gavin <alex.gavin@candelatech.com>
Signed-off-by: Alex Gavin <alex.gavin@candelatech.com>
Verified CLI:
./throughput_qos.py \
--create_sta \
--bands dualband \
--num_stations_2g 1 \
--num_stations_5g 1 \
--num_stations_6g 1 \
--ssid_2g testssid \
--ssid_5g testssid \
--ssid_6g testssid \
--passwd_2g wouldntu \
--passwd_5g like2know \
--password_6g buddyboi \
--security_2g wpa2 \
--security_5g wpa2 \
--security_6g wpa3 \
--traffic_type udp \
--tos VO,VI,BK,BE \
--upload 10000
Signed-off-by: Alex Gavin <alex.gavin@candelatech.com>
Collaborator
Author
|
Please do not merge yet. Posting for visibility. |
smileyrekiere
left a comment
smileyrekiere
left a comment
Collaborator
There was a problem hiding this comment.
For the most part comments are in the bike shed category
|
|
||
| NOTES: Desired TOS must be specified with abbreviated name in all capital letters, | ||
| for example '--tos "BK,VI,BE,VO"' | ||
| NOTES: Desired TOS value(s) must be specified with abbreviated name in all capital letters ('--tos'). |
Collaborator
There was a problem hiding this comment.
People may not know the types of service capital letters. BK, VI ,BE, VO
| Build version: 5.4.6 | ||
| kernel version: 6.2.16+ | ||
|
|
||
| The same test can be run multiple times with varying throughput by specifying multiple |
Collaborator
There was a problem hiding this comment.
The information about --bands dualband will be lost of how the stations are distributed between the bands. This comment may need to be left in.
| epilog='''\ | ||
| Create stations and endpoints and runs L3 traffic with various IP type of service(BK | BE | Video | Voice) | ||
| ''', | ||
| epilog="WiFi throughput test script with configurable ToS, rate, direction, and more.", |
Collaborator
There was a problem hiding this comment.
Possibly have comment that BK is background, BE is best effort, VI is video and VO is voice. When new to the script may not know the types of service.
|
|
||
| NOTES: Desired TOS must be specified with abbreviated name in all capital letters, | ||
| for example '--tos "BK,VI,BE,VO"' | ||
| NOTES: Desired TOS value(s) must be specified with abbreviated name in all capital letters ('--tos'). |
Collaborator
There was a problem hiding this comment.
Add the example of the types of service BK, VI, BE, VO
| logger.error("Must specify one or more number stations for the test (e.g. '--num_stations_2g 1')") | ||
| exit(1) | ||
| # Validate configuration required per-band | ||
| bands = [arg.lower() for arg in args.bands.split(",")] |
Collaborator
There was a problem hiding this comment.
nod, error checking helpful.
| required=False, | ||
| choices=["lf_udp", "lf_tcp"]) | ||
| parser.add_argument('--tos', | ||
| help='Comma-separated list of TOS values. For example, "BK,BE,VI,VO", or "BK,VO", or "VI"') |
Collaborator
There was a problem hiding this comment.
This example is helpful
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.