Fix stale notice#20
Open
kimo-works wants to merge 3 commits into
Open
Conversation
Older bundled license handlers stored inactive-license warnings as sticky Gravity Forms dismissible messages. Those messages persisted in gform_sticky_admin_messages after a site upgraded to the Hub/global-license flow, so users could still see "license has not been activated" even though Hub_Manager reported valid access via a Global License Key.\n\nRemove the sticky GF notice whenever addon access is confirmed, from both LicenseHandler and Plugin_Updater validation paths. Also guard action_admin_notices() so stale notices are consumed instead of re-added when the Hub grants access. Cleanup covers legacy download_tag keys plus canonical slug/github_name variants.
- FIX: Stale "Your … license has not been activated" admin notices now disappear automatically once a valid license key covers the plugin. They were stored as sticky Gravity Forms messages (gform_sticky_admin_messages) by older bundled handler versions and nothing ever removed them. Covered notices are now suppressed at display time and purged from the database. - FIX: License lookups by legacy addon slug (e.g. 'gravitywpapiconnector') failed because the hub matcher only compared the canonical slug. Hub_Manager::get_plugin_data() now also matches download_tag and github_name, so has_access()/notice removal work for legacy-slug add-ons.
JurriaanK
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.