Fix failing CI#1383
Merged
Merged
Conversation
mdBook 0.5 rejects unknown fields in the `[output.html]` table. The field is spelled `git-repository-url` (kebab-case); the snake_case `git_repository_url` was silently ignored by mdBook 0.4 but now fails `mdbook build`, breaking the `deploy (Book)` CI job.
The `juniper_hyper` test harness only talks to a local plain-HTTP server (http://127.0.0.1), so it never needs TLS. The `rustls` feature pulled in `aws-lc-rs`/`aws-lc-sys`, whose C build fails on Windows MSVC ("C atomics require C11 or later"), breaking the `MSRV (1.85.0, juniper_hyper, windows)` CI job. Removing the feature drops the entire `rustls`/`aws-lc-sys` chain; only plain HTTP is used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use kebab-case
git-repository-urlso mdBook 0.5 acceptsbook.toml.Drop the unused
rustlsreqwest feature whoseaws-lc-sysbuild breaksjuniper_hyperMSRV on Windows.