fix(dips): build the POI reference from the deployment chain - #1253
Open
MoonBoi9001 wants to merge 2 commits into
Open
fix(dips): build the POI reference from the deployment chain#1253MoonBoi9001 wants to merge 2 commits into
MoonBoi9001 wants to merge 2 commits into
Conversation
Collections took a recent block number from the protocol chain and looked up its hash on the deployment's own network, so an agreement indexing any other chain asked for a block that chain never produced and could never collect. The POI now uses the deployment's indexed head.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes DIPs collections reference a block of the chain the subgraph actually indexes, taking the deployment's indexed head from graph-node instead of the protocol chain's RPC height.
The collection path previously paired the protocol chain's block number with the deployment's network when asking graph-node for the block hash, so any agreement whose deployment indexes a different chain requested a block that chain has never produced, and the lookup failed on every retry, forever. Introduced with the collection implementation in #1185.
Observed on The Graph's testnet on 2026-08-07: 2 agreements on mainnet-indexing deployments had never collected since acceptance, the agent asking for mainnet block 295,717,516 (an Arbitrum Sepolia height) while mainnet's head was 25,703,982. On the production protocol chain the same defect would affect every agreement for a non-Arbitrum-One deployment. Using the indexed head also guarantees graph-node can answer the POI query, since that block is one the subgraph has indexed. A new test pins the cross-chain case, which no existing test covered.