fix(ENGKNOW-3353): pgor write randomly fails in sm#121
Open
gmagnu wants to merge 5 commits into
Open
Conversation
Contributor
gmagnu
commented
Jun 2, 2026
gmagnu
commented
- Fix missing files if pgor | write was overwriting existing gord.
- Add retry in S3 start upload.
- Dont write empty files into gord.
…ites pgor rewrites each partition's write target from `ref_af.gord/` (folder mode) to a specific `ref_af.gord/<signature>.gorz` (single-file mode). ForkWrite was creating empty gorz files for every chromosome partition that produced no rows (e.g. gorrows with a fixed range hits only 2 of ~48 partitions). These ~46 unnecessary S3 multipart uploads caused random throttling failures. Fix 1 (ForkWrite): skip empty-file creation when the write target is inside a gord folder. Empty partitions in pgor writes should produce no file; the GORDICTFOLDER step builds the dictionary from meta files and correctly excludes empty entries. Fix 2 (S3MultipartOutputStream): add retry loop to initiateMultipartUpload() matching the existing uploadWithRetry pattern, so transient S3 errors during upload initiation don't cause permanent failures. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…write-randomly-fails-in-sm
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| return sendCreateMultipartUploadRequest(req).uploadId(); | ||
| } catch (Exception e) { | ||
| throw new IOException("Failed to initiate multipart upload", e); | ||
| for (int attempt = 1; attempt <= MAX_RETRIES; attempt++) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.