Do not XOR cookie plaintext in place - #94
Open
AshSgDe29071999 wants to merge 1 commit into
Open
Conversation
encrypt and decrypt passed the caller's buffer to XORKeyStream as both dst and src, which overwrote the original slice. Copy first so Encode does not mutate caller-owned plaintext. See gorilla/csrf#201
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
encrypt and decrypt passed the caller's buffer to
cipher.Stream.XORKeyStreamas both dst and src, so Encode mutated the original plaintext slice. Callers that reuse that buffer (or that share it with csrf cookie construction) then observed ciphertext in place of the input.Copy into a new buffer before XOR. Decrypt similarly returns a distinct plaintext slice instead of aliasing the ciphertext.
Reported via gorilla/csrf#201.