Ignore gorilla.csrf.Token form field during Decode - #247
Open
AshSgDe29071999 wants to merge 1 commit into
Open
Conversation
gorilla/csrf injects a hidden field whose name contains periods. Decode split that name as a nested path and rejected the request unless IgnoreUnknownKeys was set. Skip the well-known csrf field so the two packages work together by default. See gorilla#239
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #239
gorilla/csrfposts a hidden field namedgorilla.csrf.Token.Decodesplits keys on.and treats that name as a nested struct path, so a form that is otherwise valid is rejected unlessIgnoreUnknownKeys(true)is set.Skip that well-known field so schema and csrf work together by default. Other dotted unknown keys still return
UnknownKeyError.