chore: upgrade v1.18.0#133
Conversation
| ) | ||
|
|
||
| func Opentracing(tracer opentracing.Tracer) http.Middleware { | ||
| return func(ctx http.Context) { |
There was a problem hiding this comment.
This middleware is no longer required.
There was a problem hiding this comment.
It's an example, I think.
There was a problem hiding this comment.
Pull request overview
This PR updates the Goravel example scaffold to align with newer framework/package APIs by upgrading dependencies and adjusting application code/configuration to match the updated contracts (middleware, validation rules, and new AI/telemetry features).
Changes:
- Upgrades Go/module dependencies (including Gin, Fiber, gRPC, and multiple Goravel packages) and adds a
replacepin forgithub.com/goravel/framework. - Migrates several middlewares and GraphQL routes from function-style middleware to struct-based middleware with
Handle/Signature. - Adds AI + OpenAI configuration/provider wiring, introduces telemetry/AI facades, and adds an OTEL logging channel.
Reviewed changes
Copilot reviewed 20 out of 21 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| routes/graphql.go | Converts GraphQL route middleware to struct-based middleware with signatures. |
| go.mod | Bumps Go version, upgrades dependencies, adds new Goravel modules, and adds a replace for the framework. |
| go.sum | Updates dependency checksums to match the upgraded module graph. |
| config/logging.go | Adds an otel logging channel configuration. |
| config/grpc.go | Renames gRPC connection config key from servers to clients. |
| config/ai.go | Adds AI provider configuration (OpenAI) and default provider selection. |
| bootstrap/providers.go | Registers OpenAI, telemetry, and AI service providers. |
| app/rules/exists.go | Renames custom validation rule signature to exists_custom. |
| app/http/requests/validation_create.go | Updates request validation method return types to map[string]any. |
| app/http/requests/user_create.go | Updates request rules return type to map[string]any. |
| app/http/middleware/session.go | Converts Session middleware to struct-based Handle/Signature. |
| app/http/middleware/opentracing.go | Converts Opentracing middleware to struct-based Handle/Signature. |
| app/http/middleware/lang.go | Converts Lang middleware to struct-based Handle/Signature. |
| app/http/middleware/jwt.go | Converts JWT middleware to struct-based Handle/Signature. |
| app/http/controllers/validation_controller.go | Updates inline validation rule map type to map[string]any. |
| app/http/controllers/validation_controller_test.go | Updates mock expectations to use map[string]any. |
| app/facades/telemetry.go | Adds Telemetry facade accessor. |
| app/facades/ai.go | Adds AI facade accessor. |
| .env.example | Adds OpenAI/AI provider environment variables. |
| .env | Adds OpenAI/AI provider environment variables. |
| .agents/skills/goravel-development/SKILL.md | Adds repository skill documentation for Goravel development patterns. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 22 out of 23 changed files in this pull request and generated 5 comments.
Comments suppressed due to low confidence (1)
go.mod:243
- PR title says upgrade to v1.18.0, but go.mod still requires github.com/goravel/framework v1.17.2 and uses a replace directive to pin a v1.17.2-0 pseudo-version. If v1.18.0 is available, prefer depending on the tagged release directly (and dropping replace) to make the upgrade explicit and reproducible; otherwise, consider updating the title/notes to reflect that this is a pre-release/pinned commit upgrade.
)
replace github.com/goravel/framework => github.com/goravel/framework v1.17.2-0.20260629045658-ca1f3f2b35c6
No description provided.