Skip to content

chore: upgrade v1.18.0#133

Open
hwbrzzl wants to merge 8 commits into
v1.17.xfrom
bowen/upgrade-v1.18.0
Open

chore: upgrade v1.18.0#133
hwbrzzl wants to merge 8 commits into
v1.17.xfrom
bowen/upgrade-v1.18.0

Conversation

@hwbrzzl

@hwbrzzl hwbrzzl commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@hwbrzzl hwbrzzl requested a review from a team as a code owner June 28, 2026 04:19
)

func Opentracing(tracer opentracing.Tracer) http.Middleware {
return func(ctx http.Context) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This middleware is no longer required.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an example, I think.

Copilot AI review requested due to automatic review settings July 2, 2026 08:31

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Goravel example scaffold to align with newer framework/package APIs by upgrading dependencies and adjusting application code/configuration to match the updated contracts (middleware, validation rules, and new AI/telemetry features).

Changes:

  • Upgrades Go/module dependencies (including Gin, Fiber, gRPC, and multiple Goravel packages) and adds a replace pin for github.com/goravel/framework.
  • Migrates several middlewares and GraphQL routes from function-style middleware to struct-based middleware with Handle/Signature.
  • Adds AI + OpenAI configuration/provider wiring, introduces telemetry/AI facades, and adds an OTEL logging channel.

Reviewed changes

Copilot reviewed 20 out of 21 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
routes/graphql.go Converts GraphQL route middleware to struct-based middleware with signatures.
go.mod Bumps Go version, upgrades dependencies, adds new Goravel modules, and adds a replace for the framework.
go.sum Updates dependency checksums to match the upgraded module graph.
config/logging.go Adds an otel logging channel configuration.
config/grpc.go Renames gRPC connection config key from servers to clients.
config/ai.go Adds AI provider configuration (OpenAI) and default provider selection.
bootstrap/providers.go Registers OpenAI, telemetry, and AI service providers.
app/rules/exists.go Renames custom validation rule signature to exists_custom.
app/http/requests/validation_create.go Updates request validation method return types to map[string]any.
app/http/requests/user_create.go Updates request rules return type to map[string]any.
app/http/middleware/session.go Converts Session middleware to struct-based Handle/Signature.
app/http/middleware/opentracing.go Converts Opentracing middleware to struct-based Handle/Signature.
app/http/middleware/lang.go Converts Lang middleware to struct-based Handle/Signature.
app/http/middleware/jwt.go Converts JWT middleware to struct-based Handle/Signature.
app/http/controllers/validation_controller.go Updates inline validation rule map type to map[string]any.
app/http/controllers/validation_controller_test.go Updates mock expectations to use map[string]any.
app/facades/telemetry.go Adds Telemetry facade accessor.
app/facades/ai.go Adds AI facade accessor.
.env.example Adds OpenAI/AI provider environment variables.
.env Adds OpenAI/AI provider environment variables.
.agents/skills/goravel-development/SKILL.md Adds repository skill documentation for Goravel development patterns.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread config/grpc.go Outdated
Comment thread go.mod
Comment thread go.mod Outdated
Comment thread config/ai.go
Copilot AI review requested due to automatic review settings July 3, 2026 07:12

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 22 out of 23 changed files in this pull request and generated 6 comments.

Comment thread go.mod
Comment thread go.mod Outdated
Comment thread tests/feature/http_test.go Outdated
Comment thread config/ai.go
Comment thread .env
Comment thread routes/graphql.go
Copilot AI review requested due to automatic review settings July 3, 2026 07:47

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 22 out of 23 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (1)

go.mod:243

  • PR title says upgrade to v1.18.0, but go.mod still requires github.com/goravel/framework v1.17.2 and uses a replace directive to pin a v1.17.2-0 pseudo-version. If v1.18.0 is available, prefer depending on the tagged release directly (and dropping replace) to make the upgrade explicit and reproducible; otherwise, consider updating the title/notes to reflect that this is a pre-release/pinned commit upgrade.
)

replace github.com/goravel/framework => github.com/goravel/framework v1.17.2-0.20260629045658-ca1f3f2b35c6

Comment thread config/logging.go
Comment thread app/http/middleware/opentracing.go
Comment thread routes/graphql.go
Comment thread app/rules/exists.go
Comment thread .env
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants