fix(tombstone-library): fix version.rb require and files path in gemspec template - #454
Draft
torreypayne wants to merge 1 commit into
Draft
fix(tombstone-library): fix version.rb require and files path in gemspec template#454torreypayne wants to merge 1 commit into
torreypayne wants to merge 1 commit into
Conversation
torreypayne
marked this pull request as draft
August 11, 2026 23:26
Contributor
|
You can also merge this as chore since we are not publishing anything! (it is not an actual gem) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the path to
version.rbingemspec-template.erbwhen tombstoning a gem.Technical Context
In
toys/tombstone-library/.toys.rb,generate_fileswrites the tombstone version constant to:However,
gemspec-template.erbpreviously omitted thelib/directory prefix:require File.expand_path("<%= namespace_dir %>/version", __dir__)->require File.expand_path("lib/<%= namespace_dir %>/version", __dir__)gem.files = [..., "<%= namespace_dir %>/version.rb"]->gem.files = [..., "lib/<%= namespace_dir %>/version.rb"]Failure Modes Resolved
rake build,bundle install, orGem::Specification.load) previously attempted to require<gem_root>/<namespace>/version.rb, raisingLoadError: cannot load such file.gem.filesdid not referencelib/<namespace_dir>/version.rb,gem buildfailed to includeversion.rbin the packaged.gemarchive.Repro & Verification