Skip to content

chore(spanner): add more samples#5958

Merged
olavloite merged 1 commit into
googleapis:mainfrom
olavloite:spanner-samples-1
Jun 30, 2026
Merged

chore(spanner): add more samples#5958
olavloite merged 1 commit into
googleapis:mainfrom
olavloite:spanner-samples-1

Conversation

@olavloite

Copy link
Copy Markdown
Contributor

Adds another set of samples for the Getting Started Guide for Spanner Rust.

Adds another set of samples for the Getting Started Guide for Spanner Rust.
@olavloite olavloite requested review from a team as code owners June 29, 2026 14:10
@product-auto-label product-auto-label Bot added api: spanner Issues related to the Spanner API. samples Issues that are directly related to samples. labels Jun 29, 2026
@olavloite olavloite requested a review from sakthivelmanii June 29, 2026 14:11

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several new Google Cloud Spanner examples for adding columns, querying data with a new column, and querying with parameters, supporting both Google Standard SQL and PostgreSQL dialects. It also updates the integration tests to execute these new samples. However, there are compilation errors in add_column.rs and pg_add_column.rs because set_statements expects a Vec<String> but is passed a Vec<&str>. Converting these string literals to owned Strings will resolve the compilation issues.

Comment thread src/spanner/examples/src/database/add_column.rs
Comment thread src/spanner/examples/src/database/pg_add_column.rs
@codecov

codecov Bot commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.74%. Comparing base (1ba3091) to head (0fe4f6f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5958   +/-   ##
=======================================
  Coverage   97.74%   97.74%           
=======================================
  Files         240      240           
  Lines       60692    60692           
=======================================
  Hits        59321    59321           
  Misses       1371     1371           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@olavloite olavloite merged commit 537b47b into googleapis:main Jun 30, 2026
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the Spanner API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants