Skip to content

feat(storage): implement transport, connector, worker#5956

Open
vsharonlynn wants to merge 7 commits into
googleapis:mainfrom
vsharonlynn:appendable_upload_3
Open

feat(storage): implement transport, connector, worker#5956
vsharonlynn wants to merge 7 commits into
googleapis:mainfrom
vsharonlynn:appendable_upload_3

Conversation

@vsharonlynn

Copy link
Copy Markdown
Contributor

This PR comes after PR #5932.

@product-auto-label product-auto-label Bot added the api: storage Issues related to the Cloud Storage API. label Jun 28, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the appendable_object_writer module and supporting bidi_write infrastructure to enable bidirectional streaming writes for Google Cloud Storage. Key feedback includes avoiding .expect() on parameter conversions to prevent panics, simplifying complex string-folding logic, removing an unnecessary clone of the request object, and ensuring the background worker fails loudly with an explicit error if the stream closes unexpectedly while flushes are pending.

Comment thread src/storage/src/storage/bidi_write/connector.rs Outdated
Comment thread src/storage/src/storage/bidi_write/connector.rs Outdated
Comment thread src/storage/src/storage/bidi_write/connector.rs Outdated
Comment thread src/storage/src/storage/bidi_write/connector.rs Outdated
Comment thread src/storage/src/storage/bidi_write/worker.rs Outdated
@codecov

codecov Bot commented Jun 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.36862% with 49 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.73%. Comparing base (5e91002) to head (9cca986).

Files with missing lines Patch % Lines
src/storage/src/storage/bidi_write/worker.rs 82.03% 23 Missing ⚠️
src/storage/src/storage/bidi_write/transport.rs 96.03% 12 Missing ⚠️
src/storage/src/storage/bidi_write/connector.rs 98.03% 10 Missing ⚠️
src/storage/src/storage/bidi_write/redirect.rs 95.50% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5956      +/-   ##
==========================================
+ Coverage   97.72%   97.73%   +0.01%     
==========================================
  Files         242      246       +4     
  Lines       60882    61921    +1039     
==========================================
+ Hits        59495    60519    +1024     
- Misses       1387     1402      +15     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joshuatants joshuatants left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're gone through this extensively offline.

Comment thread src/storage/src/storage/bidi_write/connector.rs Outdated
Comment thread src/storage/src/storage/bidi_write/redirect.rs Outdated
Comment thread src/storage/src/storage/bidi_write/transport.rs Outdated
@vsharonlynn vsharonlynn force-pushed the appendable_upload_3 branch 8 times, most recently from f3e8345 to 4c4b7be Compare June 29, 2026 11:57
@vsharonlynn vsharonlynn marked this pull request as ready for review June 29, 2026 12:02
@vsharonlynn vsharonlynn requested review from a team as code owners June 29, 2026 12:02
@vsharonlynn vsharonlynn force-pushed the appendable_upload_3 branch from 4c4b7be to ce34c25 Compare June 29, 2026 13:29
@vsharonlynn vsharonlynn force-pushed the appendable_upload_3 branch from 1713d73 to 9cca986 Compare June 29, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants