feat(storage): implement transport, connector, worker#5956
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces the appendable_object_writer module and supporting bidi_write infrastructure to enable bidirectional streaming writes for Google Cloud Storage. Key feedback includes avoiding .expect() on parameter conversions to prevent panics, simplifying complex string-folding logic, removing an unnecessary clone of the request object, and ensuring the background worker fails loudly with an explicit error if the stream closes unexpectedly while flushes are pending.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5956 +/- ##
==========================================
+ Coverage 97.72% 97.73% +0.01%
==========================================
Files 242 246 +4
Lines 60882 61921 +1039
==========================================
+ Hits 59495 60519 +1024
- Misses 1387 1402 +15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
joshuatants
left a comment
There was a problem hiding this comment.
We're gone through this extensively offline.
f3e8345 to
4c4b7be
Compare
4c4b7be to
ce34c25
Compare
1713d73 to
9cca986
Compare
This PR comes after PR #5932.