Skip to content

feat(o11y): extract error details and type for Discovery LROs#5955

Open
haphungw wants to merge 1 commit into
googleapis:mainfrom
haphungw:test-discovery-lro-error-tracing
Open

feat(o11y): extract error details and type for Discovery LROs#5955
haphungw wants to merge 1 commit into
googleapis:mainfrom
haphungw:test-discovery-lro-error-tracing

Conversation

@haphungw

Copy link
Copy Markdown
Contributor

Now that the generator template and the LRO macro are fixed, we implement the actual telemetry error mapping for Compute Engine LROs and adds integration test assertions.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements the error method for Operation in the generated Compute v1 client, integrates the record_discovery_polling_result! macro for tracing, and adds integration tests to verify LRO error tracing. Feedback on the changes highlights a logical bug in operation.rs where an HTTP status of 200 is mapped to Code::Unknown instead of Code::Ok, causing successful operations to be incorrectly treated as errors. Additionally, because operation.rs is a generated file, this fix must be applied to the generator template rather than the file directly.

Comment thread src/generated/cloud/compute/v1/src/operation.rs
@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.70%. Comparing base (74a8c5b) to head (21c498e).

Files with missing lines Patch % Lines
src/lro/src/internal/discovery.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5955   +/-   ##
=======================================
  Coverage   97.70%   97.70%           
=======================================
  Files         242      242           
  Lines       60891    60894    +3     
=======================================
+ Hits        59494    59498    +4     
+ Misses       1397     1396    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@haphungw haphungw force-pushed the test-discovery-lro-error-tracing branch 2 times, most recently from be5b335 to 4f74c51 Compare June 29, 2026 18:42
@haphungw haphungw marked this pull request as ready for review June 29, 2026 18:50
@haphungw haphungw requested review from a team as code owners June 29, 2026 18:50
@haphungw haphungw changed the title impl(o11y): extract error details and type for Compute LRO discovery lro error tracing feat(o11y): extract error details and type for Compute LROs Jun 29, 2026
@haphungw haphungw changed the title feat(o11y): extract error details and type for Compute LROs feat(o11y): extract error details and type for Discovery LROs Jun 29, 2026
@haphungw haphungw force-pushed the test-discovery-lro-error-tracing branch from 4f74c51 to 21c498e Compare June 29, 2026 18:53
@haphungw haphungw requested a review from westarle June 29, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant