feat(o11y): extract error details and type for Discovery LROs#5955
feat(o11y): extract error details and type for Discovery LROs#5955haphungw wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request implements the error method for Operation in the generated Compute v1 client, integrates the record_discovery_polling_result! macro for tracing, and adds integration tests to verify LRO error tracing. Feedback on the changes highlights a logical bug in operation.rs where an HTTP status of 200 is mapped to Code::Unknown instead of Code::Ok, causing successful operations to be incorrectly treated as errors. Additionally, because operation.rs is a generated file, this fix must be applied to the generator template rather than the file directly.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5955 +/- ##
=======================================
Coverage 97.70% 97.70%
=======================================
Files 242 242
Lines 60891 60894 +3
=======================================
+ Hits 59494 59498 +4
+ Misses 1397 1396 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
be5b335 to
4f74c51
Compare
4f74c51 to
21c498e
Compare
Now that the generator template and the LRO macro are fixed, we implement the actual telemetry error mapping for Compute Engine LROs and adds integration test assertions.