test(monorepo): [WIP] adds adhoc package selection for CI system tests - #17931
Draft
chalmerlowe wants to merge 12 commits into
Draft
test(monorepo): [WIP] adds adhoc package selection for CI system tests#17931chalmerlowe wants to merge 12 commits into
chalmerlowe wants to merge 12 commits into
Conversation
chalmerlowe
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces an ad-hoc testing integration into the Kokoro CI pipeline, allowing dynamic package selection based on PR labels and configuration files. The review feedback highlights several crucial robustness improvements, including handling potential grep failures under set -o pipefail in the ad-hoc test runner, authenticating GitHub API requests to prevent rate-limiting, safely parsing the API response in the inline Python snippet, and quoting variables to avoid pathname expansion.
chalmerlowe
added
test:adhoc
chalmerlowe
commented
Jul 29, 2026
yoshi-kokoro
removed
the
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[WIP]