feat: create Series.bigquery.function_name accessors for array and AEAD functions#17279
feat: create Series.bigquery.function_name accessors for array and AEAD functions#17279tswast wants to merge 9 commits into
Series.bigquery.function_name accessors for array and AEAD functions#17279Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces BigQuery Series accessors for both BigFrames and pandas Series, allowing users to call BigQuery-specific functions (such as array and AEAD encryption operations) directly on Series objects. It updates the code generation script and adds Jinja templates to generate the core, BigFrames, and pandas Series accessor classes, along with registering the new bigquery accessor and adding comprehensive unit tests. The code review feedback points out missing imports of bigframes.session in the generated templates which could cause runtime errors, and suggests using the existing OUTPUT_DIR global variable in the generator script instead of hardcoding path strings to improve maintainability.
| core_output_file = pathlib.Path("bigframes/extensions/core/series_accessor.py") | ||
| core_output_file.parent.mkdir(parents=True, exist_ok=True) | ||
| ensure_init_py( | ||
| core_output_file.parent, pathlib.Path("bigframes"), templates["license"] | ||
| ) |
There was a problem hiding this comment.
Instead of hardcoding the "bigframes" path string, use the existing OUTPUT_DIR global variable. This improves maintainability and ensures consistency with other file generation paths in the script. Additionally, ensure that you manually verify the diffs of the generated output against established golden files to prevent unintended regressions.
| core_output_file = pathlib.Path("bigframes/extensions/core/series_accessor.py") | |
| core_output_file.parent.mkdir(parents=True, exist_ok=True) | |
| ensure_init_py( | |
| core_output_file.parent, pathlib.Path("bigframes"), templates["license"] | |
| ) | |
| core_output_file = OUTPUT_DIR.joinpath("extensions/core/series_accessor.py") | |
| core_output_file.parent.mkdir(parents=True, exist_ok=True) | |
| ensure_init_py( | |
| core_output_file.parent, OUTPUT_DIR, templates["license"] | |
| ) |
References
- When modifying code generation logic, manually verify the diffs of the generated output against established golden files to ensure that changes are deterministic and do not introduce unintended regressions.
| bf_output_file = pathlib.Path("bigframes/extensions/bigframes/series_accessor.py") | ||
| bf_output_file.parent.mkdir(parents=True, exist_ok=True) | ||
| ensure_init_py( | ||
| bf_output_file.parent, pathlib.Path("bigframes"), templates["license"] | ||
| ) |
There was a problem hiding this comment.
Instead of hardcoding the "bigframes" path string, use the existing OUTPUT_DIR global variable. This improves maintainability and ensures consistency with other file generation paths in the script. Additionally, ensure that you manually verify the diffs of the generated output against established golden files to prevent unintended regressions.
| bf_output_file = pathlib.Path("bigframes/extensions/bigframes/series_accessor.py") | |
| bf_output_file.parent.mkdir(parents=True, exist_ok=True) | |
| ensure_init_py( | |
| bf_output_file.parent, pathlib.Path("bigframes"), templates["license"] | |
| ) | |
| bf_output_file = OUTPUT_DIR.joinpath("extensions/bigframes/series_accessor.py") | |
| bf_output_file.parent.mkdir(parents=True, exist_ok=True) | |
| ensure_init_py( | |
| bf_output_file.parent, OUTPUT_DIR, templates["license"] | |
| ) |
References
- When modifying code generation logic, manually verify the diffs of the generated output against established golden files to ensure that changes are deterministic and do not introduce unintended regressions.
| pd_output_file = pathlib.Path("bigframes/extensions/pandas/series_accessor.py") | ||
| pd_output_file.parent.mkdir(parents=True, exist_ok=True) | ||
| ensure_init_py( | ||
| pd_output_file.parent, pathlib.Path("bigframes"), templates["license"] | ||
| ) |
There was a problem hiding this comment.
Instead of hardcoding the "bigframes" path string, use the existing OUTPUT_DIR global variable. This improves maintainability and ensures consistency with other file generation paths in the script. Additionally, ensure that you manually verify the diffs of the generated output against established golden files to prevent unintended regressions.
| pd_output_file = pathlib.Path("bigframes/extensions/pandas/series_accessor.py") | |
| pd_output_file.parent.mkdir(parents=True, exist_ok=True) | |
| ensure_init_py( | |
| pd_output_file.parent, pathlib.Path("bigframes"), templates["license"] | |
| ) | |
| pd_output_file = OUTPUT_DIR.joinpath("extensions/pandas/series_accessor.py") | |
| pd_output_file.parent.mkdir(parents=True, exist_ok=True) | |
| ensure_init_py( | |
| pd_output_file.parent, OUTPUT_DIR, templates["license"] | |
| ) |
References
- When modifying code generation logic, manually verify the diffs of the generated output against established golden files to ensure that changes are deterministic and do not introduce unintended regressions.
There was a problem hiding this comment.
Oops. I should revert these changes. Bad merge.
1 participant
🦕