-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(storage): full object checksum: parse finalize_time and server crc32c in async object stream #17261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chandra-siri
wants to merge
6
commits into
main
Choose a base branch
from
feat/stream-checksum-metadata
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+85
−1
Open
feat(storage): full object checksum: parse finalize_time and server crc32c in async object stream #17261
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
42ab953
feat(storage): parse finalize_time and server crc32c in async object …
chandra-siri 7110744
style(storage): apply user feedback on finalize_time and fix unused i…
chandra-siri 9704da7
merge: integrate latest main to resolve pytest-asyncio event loop fai…
chandra-siri 31ef2e3
style(storage): run ruff format to resolve CI lint failures
chandra-siri c371f59
test(storage): add conftest autouse event loop fixture to resolve pyt…
chandra-siri c470641
fix(storage): use second attribute instead of seconds for DatetimeWit…
chandra-siri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -79,6 +79,9 @@ def __init__( | |
| self.socket_like_rpc: Optional[AsyncBidiRpc] = None | ||
| self._is_stream_open: bool = False | ||
| self.persisted_size: Optional[int] = None | ||
| self.is_finalized: bool = False | ||
| self.full_obj_server_crc32c: Optional[int] = None | ||
| self.object_metadata: Optional[_storage_v2.Object] = None | ||
|
|
||
| async def open(self, metadata: Optional[List[Tuple[str, str]]] = None) -> None: | ||
| """Opens the bidi-gRPC connection to read from the object. | ||
|
|
@@ -132,6 +135,18 @@ async def open(self, metadata: Optional[List[Tuple[str, str]]] = None) -> None: | |
| self.generation_number = response.metadata.generation | ||
| # update persisted size | ||
| self.persisted_size = response.metadata.size | ||
| self.object_metadata = response.metadata | ||
| if ( | ||
| hasattr(response.metadata, "finalize_time") | ||
| and response.metadata.finalize_time | ||
| and response.metadata.finalize_time.second > 0 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is it possible that this is 0? What happens if the object gets finalized exactly on a minute boundary? |
||
| ): | ||
| self.is_finalized = True | ||
| if ( | ||
| hasattr(response.metadata, "checksums") | ||
| and response.metadata.checksums | ||
| ): | ||
| self.full_obj_server_crc32c = response.metadata.checksums.crc32c | ||
|
|
||
| if response and response.read_handle: | ||
| self.read_handle = response.read_handle | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| # -*- coding: utf-8 -*- | ||
| # Copyright 2026 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| import asyncio | ||
| import pytest | ||
|
|
||
|
|
||
| @pytest.fixture(autouse=True) | ||
| def set_event_loop(): | ||
| try: | ||
| asyncio.get_running_loop() | ||
| yield | ||
| except RuntimeError: | ||
| loop = asyncio.new_event_loop() | ||
| asyncio.set_event_loop(loop) | ||
| try: | ||
| yield | ||
| finally: | ||
| loop.close() | ||
| asyncio.set_event_loop(None) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these be private similar to _is_stream_open?