chore: swap ignore-installed with upgrade flag in nox#17259
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request replaces the --ignore-installed flag with --upgrade in several session.install calls within noxfile.py.j2. The reviewer points out that using --upgrade for local paths and local dependency paths might cause pip to skip installation if the package version has not changed, potentially ignoring local code modifications. They suggest using --force-reinstall instead to ensure local changes are always picked up.
| if local_paths: | ||
| session.install(*local_paths, "--no-deps", "--ignore-installed") | ||
| session.install(*local_paths, "--no-deps", "--upgrade") |
There was a problem hiding this comment.
Using --upgrade for local paths can cause pip to skip installation if the package version has not changed. This means local code changes might not be reflected in the test session. To ensure local changes are always reinstalled, use --force-reinstall instead of --upgrade.
if local_paths:
session.install(*local_paths, "--no-deps", "--force-reinstall")
| dep_paths = [str(deps_dir / dep) for dep in core_dependencies_from_source] | ||
|
|
||
| session.install(*dep_paths, "--no-deps", "--ignore-installed") | ||
| session.install(*dep_paths, "--no-deps", "--upgrade") |
There was a problem hiding this comment.
For local dependency paths, using --upgrade might prevent pip from reinstalling them if the version hasn't been bumped. Using --force-reinstall ensures that local modifications are always picked up.
session.install(*dep_paths, "--no-deps", "--force-reinstall")
1 participant
If a local PR package has the same version number as the PyPI package already in the environment, package managers (pip or uv) will silently skip the local install. Our old workaround (--ignore-installed) forced the install, but it corrupted test environments by leaving behind duplicate .dist-info metadata.
Solution:
We split the dependency installation to handle local and external code differently:
Local packages (-e): We now use editable symlinks. Why we need this: It completely bypasses the version-matching cache. This guarantees the CI tests the unreleased PR code, without needing forceful overwrites, while dropping local installation time to zero.
PyPI packages (--upgrade): We use standard upgrades for external dependencies. It cleanly uninstalls old versions (preventing metadata corruption) while allowing the resolver to safely use its standard network cache for speed.