docs(spanner-jdbc): update connection_properties.md documentation - #14035
Open
olavloite wants to merge 2 commits into
Open
docs(spanner-jdbc): update connection_properties.md documentation#14035olavloite wants to merge 2 commits into
olavloite wants to merge 2 commits into
Conversation
Regenerate the connection_properties.md file for the Spanner JDBC driver to include the latest connection properties.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the connection properties documentation to include several new configuration options, such as dynamic channel pool watermarks, gRPC keep-alive settings, and credentials. The reviewer suggests ensuring consistency by using the lowercase form "enabledynamicchannelpool" instead of camelCase when referencing this property in the descriptions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerate the connection_properties.md file for the Spanner JDBC driver to include the latest connection properties.
This pull request also fixes a build error for the Spanner JDBC driver, as the tests for the shaded and single jar builds failed.