[anneal][v2] Add charon execution engine, expand command CLI, and integration tests#3404
Open
mdittmer wants to merge 1 commit into
Open
Conversation
This was referenced May 25, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## G3ub4smvhm3rbp6d53jhwn3knjeaw7ugn #3404 +/- ##
====================================================================
Coverage ? 91.85%
====================================================================
Files ? 20
Lines ? 6093
Branches ? 0
====================================================================
Hits ? 5597
Misses ? 496
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mdittmer
force-pushed
the
Gzq7escrh5c2qcrgidomnfaxbsi6xn7yu
branch
from
5339ec7 to
e229a98
Compare
mdittmer
force-pushed
the
Gnafivbpqcaatsvsxamgsjcudchscvaae
branch
from
e8af624 to
1c62cfd
Compare
mdittmer
force-pushed
the
Gzq7escrh5c2qcrgidomnfaxbsi6xn7yu
branch
from
e229a98 to
9450f86
Compare
mdittmer
force-pushed
the
Gnafivbpqcaatsvsxamgsjcudchscvaae
branch
from
1c62cfd to
43a1ef4
Compare
mdittmer
force-pushed
the
Gzq7escrh5c2qcrgidomnfaxbsi6xn7yu
branch
from
9450f86 to
fa0696c
Compare
mdittmer
force-pushed
the
Gnafivbpqcaatsvsxamgsjcudchscvaae
branch
2 times, most recently
from
c7bc335 to
fafcee4
Compare
mdittmer
force-pushed
the
Gzq7escrh5c2qcrgidomnfaxbsi6xn7yu
branch
2 times, most recently
from
64753f4 to
88f14ff
Compare
mdittmer
force-pushed
the
Gnafivbpqcaatsvsxamgsjcudchscvaae
branch
from
fafcee4 to
0cf1bf4
Compare
mdittmer
changed the base branch from
Gzq7escrh5c2qcrgidomnfaxbsi6xn7yu
to
G3ub4smvhm3rbp6d53jhwn3knjeaw7ugn
mdittmer
force-pushed
the
Gnafivbpqcaatsvsxamgsjcudchscvaae
branch
from
0cf1bf4 to
964666d
Compare
mdittmer
force-pushed
the
G3ub4smvhm3rbp6d53jhwn3knjeaw7ugn
branch
from
98f4d2f to
10684db
Compare
This was referenced Jun 5, 2026
joshlf
force-pushed
the
G3ub4smvhm3rbp6d53jhwn3knjeaw7ugn
branch
from
10684db to
e9b8d91
Compare
joshlf
force-pushed
the
G3ub4smvhm3rbp6d53jhwn3knjeaw7ugn
branch
from
ede12ab to
5eee5fc
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
joshlf
force-pushed
the
G3ub4smvhm3rbp6d53jhwn3knjeaw7ugn
branch
from
5eee5fc to
b45b03b
Compare
joshlf
force-pushed
the
Gnafivbpqcaatsvsxamgsjcudchscvaae
branch
from
c6dfbac to
097ab45
Compare
joshlf
force-pushed
the
Gnafivbpqcaatsvsxamgsjcudchscvaae
branch
from
097ab45 to
991f380
Compare
joshlf
force-pushed
the
G3ub4smvhm3rbp6d53jhwn3knjeaw7ugn
branch
from
b45b03b to
3b23aff
Compare
mdittmer
force-pushed
the
G3ub4smvhm3rbp6d53jhwn3knjeaw7ugn
branch
from
3b23aff to
59e0def
Compare
This was referenced Jun 15, 2026
mdittmer
force-pushed
the
Gnafivbpqcaatsvsxamgsjcudchscvaae
branch
2 times, most recently
from
4d56913 to
1161668
Compare
mdittmer
force-pushed
the
G3ub4smvhm3rbp6d53jhwn3knjeaw7ugn
branch
from
59e0def to
3007ca3
Compare
mdittmer
force-pushed
the
Gnafivbpqcaatsvsxamgsjcudchscvaae
branch
from
1161668 to
1b46c55
Compare
mdittmer
force-pushed
the
G3ub4smvhm3rbp6d53jhwn3knjeaw7ugn
branch
from
3007ca3 to
0554db7
Compare
mdittmer
force-pushed
the
Gnafivbpqcaatsvsxamgsjcudchscvaae
branch
from
1b46c55 to
8cc6e54
Compare
mdittmer
force-pushed
the
G3ub4smvhm3rbp6d53jhwn3knjeaw7ugn
branch
2 times, most recently
from
0a7d10b to
b7d2694
Compare
mdittmer
force-pushed
the
Gnafivbpqcaatsvsxamgsjcudchscvaae
branch
2 times, most recently
from
99f64a0 to
55e424e
Compare
mdittmer
force-pushed
the
G3ub4smvhm3rbp6d53jhwn3knjeaw7ugn
branch
from
b7d2694 to
419887f
Compare
mdittmer
force-pushed
the
G3ub4smvhm3rbp6d53jhwn3knjeaw7ugn
branch
from
419887f to
b986c46
Compare
mdittmer
force-pushed
the
Gnafivbpqcaatsvsxamgsjcudchscvaae
branch
2 times, most recently
from
7159849 to
fe676f8
Compare
joshlf
requested changes
Jun 29, 2026
Comment on lines
+93
to
+110
| use crate::resolve::AnnealTargetKind::*; | ||
| match artifact.target_kind { | ||
| Lib | RLib | ProcMacro | CDyLib | DyLib | StaticLib => cmd.arg("--lib"), | ||
| Bin => cmd.args(["--bin", &artifact.name.target_name]), | ||
| Example => cmd.args(["--example", &artifact.name.target_name]), | ||
| Test => cmd.args(["--test", &artifact.name.target_name]), | ||
| }; | ||
|
|
||
| // Forward all feature-related flags. | ||
| if args.features.all_features { | ||
| cmd.arg("--all-features"); | ||
| } | ||
| if args.features.no_default_features { | ||
| cmd.arg("--no-default-features"); | ||
| } | ||
| for feature in &args.features.features { | ||
| cmd.arg("--features").arg(feature); | ||
| } |
Member
There was a problem hiding this comment.
Let's do a pass at confirming that all of these argument forwards still make sense for v2.
joshlf
requested changes
Jun 29, 2026
Comment on lines
+13
to
+18
| mod charon; | ||
| mod diagnostics; | ||
| mod resolve; | ||
| mod scanner; | ||
| mod setup; | ||
| mod util; |
Member
There was a problem hiding this comment.
Why are we just adding module declarations for existing files in this PR? Does that mean they were just dumb plain text files before?
Comment on lines
-28
to
+55
| /// Path to a local dependency archive to use instead of downloading. | ||
| /// Path to a local dependency archive to use instead of downloading |
Comment on lines
-33
to
-38
| exocrate::config! { | ||
| const CONFIG: Config = Config { | ||
| rel_dir_path: [".anneal", "toolchain"], | ||
| versioned_files: &["../Cargo.toml", "../Cargo.lock"], | ||
| }; | ||
| } |
Comment on lines
-40
to
-46
| exocrate::parse_remote_archive! { | ||
| const REMOTE: RemoteArchive = "Cargo.toml" [ | ||
| (linux, x86_64), | ||
| (macos, x86_64), | ||
| (linux, aarch64), | ||
| (macos, aarch64), | ||
| ]; |
| fn setup(args: SetupArgs) { | ||
| let installation_dir = setup_installation_dir(args); | ||
| log::info!("anneal toolchain is installed at {:?}", installation_dir); | ||
| fn expand(args: ExpandArgs) -> anyhow::Result<()> { |
Member
There was a problem hiding this comment.
Let's call this generate (and the associated CLI command) consistent with v1?
| fn setup(args: SetupArgs) { | ||
| let installation_dir = setup_installation_dir(args); | ||
| log::info!("anneal toolchain is installed at {:?}", installation_dir); | ||
| fn expand(args: ExpandArgs) -> anyhow::Result<()> { |
Member
There was a problem hiding this comment.
This is private to this module but doesn't appear to be called.
Maybe it's time to deny warnings in CI so that we catch things like this? Specifically, maybe we can take a rough pass at copying the compiler and Clippy lints that we enable in zerocopy, enabling them here, and then denying warnings in CI (via RUSTFLAGS='-Dwarnings')? Presumably as a separate PR, ideally as low (ie, close to main) in this PR stack as possible.
More generally, let's make sure that these sorts of lints are actually getting exercised in CI. If I'm right that this isn't called, and since it seems like we set RUSTFLAGS='-Dwarnings' in the anneal.yml CI job, then it's fishy that CI is passing on this PR.
…egration tests gherrit-pr-id: Gnafivbpqcaatsvsxamgsjcudchscvaae
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest Update: v42 — Compare vs v41
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Gnafivbpqcaatsvsxamgsjcudchscvaae && git checkout -b pr-Gnafivbpqcaatsvsxamgsjcudchscvaae FETCH_HEADCheckout
git fetch origin refs/heads/Gnafivbpqcaatsvsxamgsjcudchscvaae && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Gnafivbpqcaatsvsxamgsjcudchscvaae && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.