Skip to content

Fix abseil lock deprecations#644

Open
aDotInTheVoid wants to merge 1 commit into
google:mainfrom
aDotInTheVoid:abseil-deprecations
Open

Fix abseil lock deprecations#644
aDotInTheVoid wants to merge 1 commit into
google:mainfrom
aDotInTheVoid:abseil-deprecations

Conversation

@aDotInTheVoid

Copy link
Copy Markdown

Fixes #631

These were deprecated in abseil/abseil-cpp@6d8e1a5

@google-cla

google-cla Bot commented Jun 29, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

aindlq added a commit to aindlq/qlever that referenced this pull request Jul 6, 2026
Bump the FetchContent pins to unblock the MinGW/Windows build. s2 stays at
v0.13.1 (not v0.14.0) so it still builds under gcc-8
(google/s2geometry#568).

Adaptations for the newer deps: -Wno-deprecated-declarations on re2 (dfa.cc
uses absl::Mutex methods deprecated in 20260107,
google/re2#631 and
google/re2#644), -Wno-nullability-completeness on s2
(as upstream does, google/s2geometry#601), and
migrating SpatialJoinCachedIndex to the non-deprecated FullDecodeShapeFactory
overload.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Abseil LTS 20260107 deprecates MutexLock(Mutex*) and bare Mutex::ReaderLock() / WriterLock() / *Unlock() — used in re2/dfa.cc

1 participant