Standardize property attributes and refactor private properties.#302
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_949022418
branch
from
July 17, 2026 20:25
004cece to
1c61fc7
Compare
This change: * Explicitly adds `nonatomic` to properties where thread safety is not required, improving performance. * Adds `atomic` to class properties and other properties where thread safety is important. * Refactors private properties in `ITRTestTraceRecorder` to be instance variables. * Simplifies the `EDODeviceDetector` by removing a redundant `started` property and using the channel's existence. PiperOrigin-RevId: 949734296
copybara-service
Bot
force-pushed
the
test_949022418
branch
from
July 17, 2026 20:29
1c61fc7 to
51f78db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standardize property attributes and refactor private properties.
This change:
nonatomicto properties where thread safety is not required, improving performance.atomicto class properties and other properties where thread safety is important.ITRTestTraceRecorderto be instance variables.EDODeviceDetectorby removing a redundantstartedproperty and using the channel's existence.