Skip to content

Add tags forwarding to GenKtTests macro. #5197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
copybara-service wants to merge 1 commit into from
+7 −3
Closed

Add tags forwarding to GenKtTests macro. #5197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions javatests/dagger/functional/kotlinsrc/multibindings/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ GenKtTests(
name = "MapKeyWithDefaultTest",
srcs = ["MapKeyWithDefaultTest.kt"],
javacopts = DOCLINT_HTML_AND_SYNTAX + DOCLINT_REFERENCES,
tags = ["disable-turbine-apt"],
deps = [
"//third_party/java/auto:value",
"//third_party/java/dagger",
Expand Down
9 changes: 6 additions & 3 deletions test_defs.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,8 @@ def GenKtTests(
gen_library_deps = None,
plugins = None,
javacopts = None,
shard_count = None):
shard_count = None,
tags = None):
_GenTestsWithVariants(
library_rule_type = kt_jvm_library,
test_rule_type = kt_jvm_test,
Expand All @@ -101,6 +102,7 @@ def GenKtTests(
plugins = plugins,
javacopts = javacopts,
shard_count = shard_count,
user_tags = tags,
)

def GenJavaLibrary(
Expand Down Expand Up @@ -178,7 +180,8 @@ def _GenTestsWithVariants(
plugins,
javacopts,
shard_count,
test_kwargs = None):
test_kwargs = None,
user_tags = None):
test_files = [src for src in srcs if _is_test(src)]
supporting_files = [src for src in srcs if not _is_test(src)]

Expand Down Expand Up @@ -212,7 +215,7 @@ def _GenTestsWithVariants(
variant_javacopts = [_JAVACOPTS[variant.backend], _JAVACOPTS[variant.codegen]]
variant_library_rule_type = library_rule_type
variant_test_rule_type = test_rule_type
tags = []
tags = list(user_tags or [])
jvm_flags = []

if variant.flavors:
Expand Down
Loading