feat: Integrate mTLS support into Agent Registry API calls#5861
Open
agrawalradhika-cell wants to merge 3 commits into
Open
feat: Integrate mTLS support into Agent Registry API calls#5861agrawalradhika-cell wants to merge 3 commits into
agrawalradhika-cell wants to merge 3 commits into
Conversation
Collaborator
|
Response from ADK Triaging Agent Hello @agrawalradhika-cell, thank you for creating this PR! While reviewing your PR, I noticed a few items from our contribution guidelines are currently missing or incomplete:
Providing this information will help our reviewers review your PR more efficiently. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
2. Or, if no issue exists, describe the change:
Problem:
The current
AgentRegistryclient useshttpx.Clientfor API requests, which does not inherently support the mTLS (mutual TLS) requirements and automatic endpoint selection needed for secure Google API interactions.Solution:
Integrated mTLS support by transitioning the
AgentRegistryclient to usegoogle.auth.transport.requests.AuthorizedSession. This change allows the client to:GOOGLE_API_USE_CLIENT_CERTIFICATEandGOOGLE_API_USE_MTLS_ENDPOINT.agentregistry.googleapis.com) and mTLS (agentregistry.mtls.googleapis.com) endpoints.Testing Plan
Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.
Unit Tests:
Please include a summary of passed
pytestresults.Manual End-to-End (E2E) Tests:
Checklist
Additional context
Add any other context or screenshots about the feature request here.