feat(export): support exporting shadows to css-vars and tailwind-v4 - #168
Open
zachshallbetter wants to merge 10 commits into
Open
feat(export): support exporting shadows to css-vars and tailwind-v4#168zachshallbetter wants to merge 10 commits into
zachshallbetter wants to merge 10 commits into
Conversation
…w dimension units; generalize PropertyDef
…ion token refs; surface non-string values as findings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented support for exporting the newly proposed structured
shadowstoken category inside bothcss-varsandtailwind-v4emitters (resolves Issue #92).Background & Motivation
PR #163 introduced the schemas, parsing models, linter rules, and documentation for the new
shadowscategory. However, because the exporters were left unmodified, design systems containing shadow tokens could not serialize them into CSS variables or Tailwind output.Relation to other PRs
Changes
TailwindV4ThemeDataSchemaintailwind/v4/spec.tsto include theshadowrecord namespace.css-vars/handler.tsto mapstate.shadowsto--shadow-*custom property declarations.tailwind/v4/handler.tsto map shadows into the Tailwind v4 theme undertheme.shadow.['shadow', '--shadow-']category prefix to the Tailwind serializer list intailwind/v4/serialize.tsto output theme properties correctly.0pxfor missing layout parameters andtransparentfor missing colors) to verify valid box-shadow CSS is always emitted.spec.test.tswhere the expected JSON rules length assertion was out of sync with the new linter rules introduced in PR feat: add structured shadows/elevation token category #163.css-vars/handler.test.tsto check shadows serialization and default fallbacks.tailwind/v4/handler.test.tsandtailwind/v4/serialize.test.tsto verify theme mapping and CSS block ordering.