This repository was archived by the owner on Aug 25, 2026. It is now read-only.
Allow hashable axis names in shape checks - #142
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Conversation
Penzai named arrays support arbitrary hashable axis names, including TmpPosAxisMarker for temporary positional-axis bindings. check_structure still asserted that named-axis keys captured through an unpacked **var(...) binding were strings, both when inlining a solved mapping and when re-associating the final match result. Remove those string-only assertions while preserving the existing matching logic. Regression coverage includes repeated unpacked named-axis variables with a TmpPosAxisMarker and the Linear reproduction from issue google-deepmind#132. Closes google-deepmind#132
sylvesterkaczmarek
marked this pull request as ready for review
August 15, 2026 16:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Penzai named arrays support arbitrary hashable axis names, including TmpPosAxisMarker for temporary positional-axis bindings. check_structure still asserted that named-axis keys captured through an unpacked **var(...) binding were strings, both when inlining a solved mapping and when re-associating the final match result.
Remove those string-only assertions while preserving the existing matching logic.
Regression coverage includes repeated unpacked named-axis variables with a TmpPosAxisMarker and the Linear reproduction from issue #132.
Closes #132