Resolve the OpenGL backend lazily so import mujoco works without OpenGL libraries#3366
Open
kevinzakka wants to merge 1 commit into
Open
Resolve the OpenGL backend lazily so import mujoco works without OpenGL libraries#3366kevinzakka wants to merge 1 commit into
kevinzakka wants to merge 1 commit into
Conversation
import mujoco no longer requires the OpenGL libraries when rendering is unused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
import mujoco currently fails on machines that don't have OpenGL installed, even if you never render anything. The reason is that mujoco loads the GL backend immediately at import time.
This PR makes it lazy: the backend loads only when you actually create a GLContext. So import mujoco works everywhere, and you get a clear error only if you try to render without OpenGL available.
Includes a test.