Fix mjpython libpython resolution for uv and @rpath interpreters#3355
Open
Mika412 wants to merge 3 commits into
Open
Fix mjpython libpython resolution for uv and @rpath interpreters#3355Mika412 wants to merge 3 commits into
Mika412 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS, running anything under
mjpythonon auvmanaged Python fails withdyld: Library not loaded: @rpath/libpython3.x.dylib. The same failure occurs with any interpreter that links libpython through@rpath.At startup,
mjpython.pyparsesotool -land adds the interpreter's library directories toDYLD_FALLBACK_LIBRARY_PATHso libpython resolves. Two bugs broke that for@rpathinterpreters:dirname()on every entry, butLC_RPATHvalues are already directories, so the reallib/got reduced to its parent and libpython was never found.bin/pythonpoints at the base interpreter) the paths were anchored in the wrong place.Also swaps the main-thread startup busy-wait (
while (!py_initialized.load()) {}) for a dispatch semaphore, and makes the three interpreter-bootstrap calls fail loudly instead of silently continuing into a broken state.All changes are limited to the macOS-only mjpython launcher (
python/mujoco/mjpython/). Nothing else is affected.This fixes the failure reported in #1923 (closed without a fix) and astral-sh/uv#8953.