fix(security): pin etils-actions/pypi-auto-publish to commit SHA in publish workflow#710
Open
XananasX7 wants to merge 1 commit into
Open
fix(security): pin etils-actions/pypi-auto-publish to commit SHA in publish workflow#710XananasX7 wants to merge 1 commit into
XananasX7 wants to merge 1 commit into
Conversation
…to SHAs Tag-pinned third-party actions (etils-actions/pypi-auto-publish@v1) in publish workflows can be redirected to malicious code. A compromised tag would execute with PYPI_API_TOKEN access, enabling a supply-chain attack on every downstream user. Pin to immutable commit SHA.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
pytest_and_autopublish.ymlworkflow usesetils-actions/pypi-auto-publish@v1— a mutable tag reference on a third-party action. If thev1tag is silently redirected (compromised maintainer, tag deletion + recreation, repo takeover), malicious code executes in the job that holdsPYPI_API_TOKEN, enabling a supply-chain attack on every downstream user of this package.Fix
Pin to the immutable commit SHA of the current
v1tag (@e3c4b4af…), with the tag preserved as a comment. All other tag-pinned actions (checkout, setup-python) also pinned to SHAs.Follows the GitHub security hardening guide.