Bump React Router to 7.18.2 for __manifest DoS CVEs - #31
Open
goodeats wants to merge 3 commits into
Open
Conversation
Upgrade react-router and @react-router/* from 7.4.0 to 7.18.2, and @remix-run/server-runtime from 2.16.2 to 2.17.5, to pick up the Framework Mode __manifest denial-of-service fixes (CVE-2026-42342, CVE-2026-55685). Keep remix-flat-routes and the remix-routes adapter. Update loader test args for the 7.16+ url/pattern fields on LoaderFunctionArgs. Co-authored-by: Pat Needham <p@patn.dev>
React Router 7.18 typegen no longer exports Info from +types modules. Switch those compile-only imports to Route.ComponentProps loader/action data so typecheck passes. No dashboard or marketing behavior changes. Co-authored-by: Pat Needham <p@patn.dev>
React Router 7.18 can pull the icon spritesheet into the e2e import graph. Playwright then parses sprite.svg as JavaScript and fails collection. Rewrite .svg imports to a string stub in the Playwright Babel transform only. Co-authored-by: Pat Needham <p@patn.dev>
goodeats
marked this pull request as ready for review
August 19, 2026 22:05
This was referenced Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #24
Upgrade this app off React Router 7.4.0 far enough to fix the Framework Mode
__manifestdenial-of-service CVEs. This does not stop at Epic Stack’s 7.16.0.react-router7.15.0+,@remix-run/server-runtime2.17.5+react-router7.18.0+Summary
react-routerand@react-router/*from^7.4.0to^7.18.2(latest patched 7.x; not a major jump to 8.x)@remix-run/server-runtimefrom^2.16.2to^2.17.5@react-router/remix-routes-option-adapteron the same 7.x lineremix-flat-routes; do not addreact-router-auto-routesorreact-router-devtoolsurl/patternfields onLoaderFunctionArgsInfofrom+typesmodules. Replace those compile-only imports withRoute.ComponentProps['loaderData' | 'actionData']sotscpasses. No dashboard CRUD or marketing copy changes.sprite.svgas JS. Stub Vite.svgimports in the Playwright Babel transform only.npm ls(direct deps)Intentionally not bumped
Vite 6.2.2, Vitest 3.0.9, Express 4.21.2, Sentry 9.8.0, Prisma 6.5.0,
litefs-js1.1.2, and routing migration (packages 2–7 / issues 25–30). Not based on PR #21.Files changed
Allowed by the issue:
package.jsonpackage-lock.jsonapp/routes/_auth+/auth.$provider.callback.test.ts(loader args now requireurlandpattern)app/routes/users+/$username.test.tsx(sameLoaderFunctionArgsrequirement; test-only)Required for typecheck after the 7.18 typegen
Infoexport removal (listed per the parent issue’s compile-breakage rule):app/routes/_marketing+/index.tsx(type imports only)app/routes/dashboard+/__about-editor.tsxapp/routes/dashboard+/__contact-editor.tsxapp/routes/dashboard+/__layout.tsxapp/routes/dashboard+/__project-editor.tsxapp/routes/dashboard+/__project-skills-editor.tsxapp/routes/dashboard+/__skill-editor.tsxapp/routes/dashboard+/about.index.tsxapp/routes/dashboard+/contacts.index.tsxapp/routes/dashboard+/projects.index.tsxapp/routes/dashboard+/skills.index.tsxapp/routes/settings+/profile.connections.tsxapp/routes/settings+/profile.index.tsxapp/routes/users+/$username_+/__note-editor.tsxapp/routes/users+/$username_+/notes.$noteId.tsxapp/routes/users+/$username_+/notes.index.tsxRequired for Playwright after the bump (test-only):
playwright.config.tstests/svg-import-stub.cjsTest Plan
react-router/@react-router/*≥ 7.18.0 and@remix-run/server-runtime≥ 2.17.5npm run typecheck(local + CI)npm run test -- --run(local + CI)npm run lint(local + CI; existing unused-var warning inapp/root.tsxonly)npm run build(local; Vite remains 6.2.2)sprite.svgSyntaxError/ “No tests found”. Addressed with the test-only SVG stub.origin/devpush run: both stuck ~60 minutes on Install Playwright Browsers and then cancelled. That hang is a pre-existing CI flake unrelated to this bump (same install step, same workflow, before tests run).Checklist
Screenshots
N/A — dependency CVE bump plus type-only compile fixes.
Staging smoke (human, after merge to
dev)